FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "deps: delete OpenSSL demos, doc and test folders" by richardlau · Pull Request #58099 · nodejs/node · GitHub

/ node Public

Revert "deps: delete OpenSSL demos, doc and test folders" - #58099

Closed
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:revert-57835
Closed

Revert "deps: delete OpenSSL demos, doc and test folders"#58099
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:revert-57835

Conversation

Copy link
Copy Markdown
Member

This reverts commit dfaded8.

It turns out that at least the docs are required to run the OpenSSL scripts that we run to generate the per-arch configurations under deps/openssl/config/archs.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 1, 2025
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2025
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 1, 2025

This comment was marked as outdated.

richardlau removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 1, 2025

Copy link
Copy Markdown
Collaborator

richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 1, 2025

targos commented May 23, 2025

Copy link
Copy Markdown
Member

I opened #58431 as an alternative.

richardlau closed this May 29, 2025
richardlau deleted the revert-57835 branch May 29, 2025 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL