FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,deps,tools: prepare to update to OpenSSL 3.5 by richardlau · Pull Request #58098 · nodejs/node · GitHub

/ node Public

build,deps,tools: prepare to update to OpenSSL 3.5 - #58098

Closed
richardlau wants to merge 3 commits into
mainfrom
openssl-3.5-test
Closed

build,deps,tools: prepare to update to OpenSSL 3.5#58098
richardlau wants to merge 3 commits into
mainfrom
openssl-3.5-test

Conversation

Copy link
Copy Markdown
Member

This is a replacement for #57795. I'm opening a new PR as I had to revert #57835 to get the arch specific files (which run part of OpenSSL's build) to work.

  • 4568a35 test: prepare test-crypto-rsa-dsa for newer OpenSSL4568a35077a test: prepare test-crypto-rsa-dsa for newer OpenSSL is needed to pass tests -- the test was assuming OpenSSL 3.0 behaviour which has changed. I left both code paths in this commit so that tests will pass on it (and will pass on the later commit once OpenSSL 3.5 is introduced).
  • 155fd5b build,deps,tools: update to OpenSSL 3.5 -- this is the main update, including fixing up the perl scripts and Makefiles in deps/openssl/config for the new files in OpenSSL 3.5. I'm not wholly happy with the amount of places that need to be updated to add each newly introduced file but that's a possible later improvement (I'm not that familiar with Perl).

Note that this PR doesn't do the actual update -- I'm intending for that to be done via the updater workflow once this lands (otherwise this PR will have far too many changed files to be reviewable).

cc @nodejs/crypto


Running the automation to test: https://github.com/nodejs/node/actions/runs/14779389322/job/41494768590
Which is opening #58097

richardlau and others added 3 commits May 1, 2025 16:46
Update `parallel/test-crypto-rsa-dsa` to prepare for updating
`deps/openssl` to later versions of OpenSSL which support implicit
rejections with `RSA_PKCS1_PADDING`.
Co-Authored-By: Richard Lau <rlau@redhat.com>

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels May 1, 2025

Copy link
Copy Markdown
Member Author

Note that this PR doesn't do the actual update -- I'm intending for that to be done via the updater workflow once this lands (otherwise this PR will have far too many changed files to be reviewable).

Hah, I forgot that the revert changes thousands of files. Should I open that separately to aid reviewing this PR?

Copy link
Copy Markdown
Member Author

Note that this PR doesn't do the actual update -- I'm intending for that to be done via the updater workflow once this lands (otherwise this PR will have far too many changed files to be reviewable).

Hah, I forgot that the revert changes thousands of files. Should I open that separately to aid reviewing this PR?

oh I have lint failures too so I'll have to update anyway. I'll rework this into two PRs.

Copy link
Copy Markdown
Member Author

Replaced by #58099 and #58100.

richardlau closed this May 1, 2025
richardlau deleted the openssl-3.5-test branch May 1, 2025 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL