stream: update iterable streams to use budget backpressure - #64464
Closed
jasnell wants to merge 3 commits into
Closed
stream: update iterable streams to use budget backpressure#64464jasnell wants to merge 3 commits into
jasnell wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
bjohansebas
approved these changes
Jul 13, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 90.54054% with 21 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## main #64464 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 741 741
Lines 242196 242159 -37
Branches 45606 45611 +5
==========================================
- Hits 218246 218237 -9
Misses 15438 15438
+ Partials 8512 8484 -28
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
pimterry
reviewed
Jul 13, 2026
Comment thread
doc/api/stream_iter.md
Outdated
Comment thread
lib/internal/streams/iter/push.js
Comment thread
lib/internal/streams/iter/push.js
Comment thread
lib/internal/streams/iter/broadcast.js
Outdated
Comment thread
lib/internal/streams/iter/push.js
Outdated
Comment thread
lib/internal/streams/iter/utils.js
Outdated
jasnell
force-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
939e46e to
9ae61ff
Compare
July 20, 2026 22:31
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
9ae61ff to
c55171f
Compare
July 20, 2026 22:48
This comment was marked as outdated.
pimterry
approved these changes
Jul 21, 2026
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
c55171f to
efe85ee
Compare
July 21, 2026 13:31
This comment was marked as low quality.
jasnell
force-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
efe85ee to
5f41022
Compare
July 21, 2026 23:58
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
approved these changes
Jul 22, 2026
trivikr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Jul 22, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Updates the implementation to use the updated backpressure model that landed here: WinterTC55/iter-streams#23 Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/iter-streams-backpressure-new
branch
from
f059d7e to
da87db0
Compare
July 22, 2026 17:43
This comment was marked as outdated.
trivikr
approved these changes
Jul 22, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Ethan-Arrowood
approved these changes
Jul 23, 2026
Ethan-Arrowood
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'm still getting familiar with the iter-streams proposal and quic implementation. LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
From CI and approvals perspective, this PR is ready to merge unless author needs review from all requested reviewers. The latest https://ci.nodejs.org/job/node-test-commit-osx/71672/ is successful, and GitHub UI is showing the old one for some reason. |
Sorry, something went wrong.
This comment was marked as duplicate.
jasnell
added a commit
that referenced
this pull request
Jul 23, 2026
Updates the implementation to use the updated backpressure model that landed here: WinterTC55/iter-streams#23 Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell
added a commit
that referenced
this pull request
Jul 23, 2026
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
jasnell
added a commit
that referenced
this pull request
Jul 23, 2026
PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
Updates the implementation to use the updated backpressure model that landed here: WinterTC55/iter-streams#23 Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Updates the implementation to use the updated backpressure model that landed here: WinterTC55/iter-streams#23 Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
PR-URL: #64464 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinterTC55/iter-streams#23 updated the backpressure model in the iterable streams specification to use a byte-budget model. This PR updates the implementation to match.
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus