FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(select): add a top expanded select example by boaz0 · Pull Request #2026 · patternfly/patternfly · GitHub

/ patternfly Public

docs(select): add a top expanded select example - #2026

Merged
mcoker merged 1 commit into
patternfly:masterfrom
boaz0:closes_1986
Sep 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

docs(select): add a top expanded select example#2026
mcoker merged 1 commit into
patternfly:masterfrom
boaz0:closes_1986

Conversation

boaz0 commented Jul 8, 2019

Copy link
Copy Markdown
Member

closes #1986

//cc @tlabaj @mcoker

patternfly-build commented Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Deploy preview for pf-next ready!

Built with commit 26b59efaefdf9f58f1b7e5611ac503e844d4d33f

https://deploy-preview-2026--pf-next.netlify.com

mcoker commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

thanks @boaz0! left a couple of comments.

mcoker reviewed Jul 11, 2019
View reviewed changes
Comment thread src/patternfly/components/Select/select.scss Outdated
mcoker reviewed Jul 30, 2019
View reviewed changes
Comment thread src/patternfly/components/Select/select.scss Outdated

patternfly-build commented Aug 7, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-Next preview: https://patternfly-next-pr-2026.surge.sh

mcoker reviewed Sep 13, 2019
View reviewed changes
Comment thread src/patternfly/components/Select/select.scss Outdated

mcoker commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Can you also document this example so that we have the .pf-m-top class documented?

mcoker mentioned this pull request Sep 13, 2019
Closed

boaz0 commented Sep 15, 2019

Copy link
Copy Markdown
Member Author

Thanks @mcoker
I updated this PR according to your PR. 😄

mcoker reviewed Sep 16, 2019
View reviewed changes
Comment thread src/patternfly/components/Select/examples/select-single-top-expanded-example.hbs Outdated

mcoker Sep 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
{{#> select id="select-single-top-expanded" select-menu-modifier="pf-m-top" select--IsExpanded="true"}}
{{#> select id="select-single-top-expanded" select-menu--modifier="pf-m-top" select--IsExpanded="true"}}

boaz0 Sep 17, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

shouldn't it be select--modifier?

mcoker Sep 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@boaz0 oh nope, since we're adding .pf-m-top to .pf-m-select__menu, not .pf-c-select.

mcoker reviewed Sep 16, 2019
View reviewed changes
Comment thread src/patternfly/components/Select/select.hbs Outdated
mcoker reviewed Sep 16, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good! just a couple of small things.

docs(select): add a top expanded select example
7c385a0 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
mcoker approved these changes Sep 19, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nice! thanks @boaz0!

mcoker merged commit 296f04c into patternfly:master Sep 19, 2019

redallen commented Sep 19, 2019

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

boaz0 commented Sep 20, 2019

Copy link
Copy Markdown
Member Author

Thank you @mcoker !!!

boaz0 deleted the closes_1986 branch September 20, 2019 12:26
rachael-phillips added a commit that referenced this pull request Sep 27, 2019
Update 2019.08 release notes (2019-10-01)
6c62401 
# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))
redallen pushed a commit that referenced this pull request Oct 1, 2019
Update RELEASE-NOTES.md [ci skip] (#2306)
dc2f484 
* Create 2019.08 release notes (2019-10-01)

Adding new release notes

* Update 2019.08 release notes (2019-10-01)

# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))

* Rename 2019.08 release notes (2019-10-01) to 2019.08 release notes (2019-10-01).MD

Added .md file name

* Update 2019.08 release notes (2019-10-01).MD

Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com>

* alphabetize components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL