FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(demo): add empty and loading state table demos by mcoker · Pull Request #2254 · patternfly/patternfly · GitHub

/ patternfly Public

fix(demo): add empty and loading state table demos - #2254

Merged
mattnolting merged 7 commits into
patternfly:masterfrom
mcoker:issue-2171
Sep 13, 2019
ConversationCommits (7)ChecksFiles changed
Merged

fix(demo): add empty and loading state table demos#2254
mattnolting merged 7 commits into
patternfly:masterfrom
mcoker:issue-2171

Conversation

mcoker commented Sep 11, 2019

Copy link
Copy Markdown
Contributor
  • also added primary action container to empty state to support designs

fixes #2171

fix(demo): add empty and loading state table demos
e8196dd 
* also added primary action container to empty state to support designs

patternfly-build commented Sep 11, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-Next preview: https://patternfly-next-pr-2254.surge.sh

refactor(demo): update table loading state demo to use empty state
29a0c8f 
Also updated .pf-c-empty-state__icon to be a container instead of just an icon.
mcarrano suggested changes Sep 12, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The empty state should somehow sit inside the table area. Right now in looks like it's overlayed on top of the table.

mcoker commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

@mcarrano updated the preview, would you mind checking again?

mcoker closed this Sep 12, 2019
mcoker reopened this Sep 12, 2019
mcarrano approved these changes Sep 12, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good now @mcoker

mattnolting approved these changes Sep 13, 2019
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Good work 👍

Comment thread src/patternfly/components/EmptyState/empty-state-icon.hbs
{{/if}}>
{{> @partial-block}}
</div>
{{else}}

mattnolting Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🔥

mattnolting reviewed Sep 13, 2019
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like there are a few axe issues

Comment thread src/patternfly/demos/Table/table-loading-table.hbs Outdated
Comment thread src/patternfly/demos/Table/examples/table-loading-demo.hbs Outdated
Comment thread src/patternfly/demos/Table/examples/table-empty-state-demo.hbs Outdated
Comment thread src/patternfly/demos/Table/table-loading-table.hbs Outdated
mattnolting self-requested a review September 13, 2019 19:10
mcoker and others added 4 commits September 13, 2019 14:32
Update src/patternfly/demos/Table/examples/table-loading-demo.hbs
c58372c 
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Update src/patternfly/demos/Table/table-loading-table.hbs
285422d 
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Update src/patternfly/demos/Table/examples/table-empty-state-demo.hbs
1b0acb3 
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>
Update src/patternfly/demos/Table/table-loading-table.hbs
0e0655b 
Co-Authored-By: Matt Nolting <matthew.nolting@gmail.com>

mcoker commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

@mattnolting thanks! build passes now.

mattnolting approved these changes Sep 13, 2019
View reviewed changes

mattnolting left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💪 LGTM

mattnolting merged commit 0eedc8c into patternfly:master Sep 13, 2019

redallen commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.31.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Sep 13, 2019
Closed
Closed
rachael-phillips added a commit that referenced this pull request Sep 27, 2019
Update 2019.08 release notes (2019-10-01)
6c62401 
# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))
redallen pushed a commit that referenced this pull request Oct 1, 2019
Update RELEASE-NOTES.md [ci skip] (#2306)
dc2f484 
* Create 2019.08 release notes (2019-10-01)

Adding new release notes

* Update 2019.08 release notes (2019-10-01)

# 2019.08 release notes (2019-10-01)
Packages released:
- @patternfly/patternfly@2.x

## Components
- **Charts:** 
  - Adjust padding for pie and donut charts ([#2247](#2247))
  - Set mix-blend-mode for better color contrast ([#2239](#2239))
  - Update area chart opacity ([#2233](#2233))
- **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260))
- **Data list:** Make data list borders consistent with table ([#2289](#2289))
- **Data toolbar:** 
  - Updated clear button mods ([#2248](#2248))
  - Added in examples for expandable ([#2273](#2273))
- **Flex layout:** Wrapped flex items, update css ([#2214](#2214))
- **Wizard:**
  - Re-enabled wizard modal demos ([#2259](#2259))
  - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296))
- **Navigation:** Added styling updates to dark nav ([#2283](#2283))
- **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264))
- **Pagination:** Added compact variation ([#2275](#2275))
- **Radio:** Updated the radio component example to single components ([#2231](#2231))
- **Table:**
  - Fixed a11y issues in org documentation/html/table ([#2282](#2282))
  - Added empty and loading state table demos ([#2254](#2254))
- **Tooltip:** Added text align left modifier ([#2284](#2284))
- **Select:**
  - Added typeahead form wrapper, udpated css ([#2255](#2255))
  - Add top expanded example ([#2026](#2026))
- **Chip group:** Add overflow to group ([#2278](#2278))
- **Button:** Add control modifier ([#2005](#2005))

## Other
- **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))

* Rename 2019.08 release notes (2019-10-01) to 2019.08 release notes (2019-10-01).MD

Added .md file name

* Update 2019.08 release notes (2019-10-01).MD

Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com>

* alphabetize components
mcoker deleted the issue-2171 branch December 16, 2019 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattnolting mattnolting approved these changes
+1 more reviewer
mcarrano mcarrano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL