Make data list consistent with table by christiemolloy · Pull Request #2289 · patternfly/patternfly · GitHub

When reviewing, refer to #2185 for the slides that @mmenestr made!

PatternFly-Next preview: https://patternfly-next-pr-2289.surge.sh

Sorry I'm probably just missing this somewhere, but is there a list of what needs to change to what? Is that in this spreadsheet?

I'm still seeing differences in this PR, like this:

table

data list

@mcoker here is the link to the slide share that Margo made: https://docs.google.com/presentation/d/1fLp8424_ykHEyS5K2kkGsfklE3tfIQCBy0eTu1G19go/edit#slide=id.g5e8e11457d_0_0 and I updated that bottom-border. Do you see anything else?

@christiemolloy I don't see anywhere in the linked spreadsheet which values are correct - it's just pointing out differences. Same with #2185, it just lists the differences but doesn't say which is correct.

Sorry, the values in the table are correct @mcoker

still need to add this line back in so it isn't a breaking change.

Just need to add back that border-bottom declaration so it isn't a breaking change, then looks good to me!

A couple of questions that are outside the scope of this PR.

Should we display the thick mobile borders between rows on data list when it breaks to a responsive view the same way we do with table?
Should the same border between the expandable row and expanded content exist between data list and table?

datalist

table

@mcoker great questions. The examples for data-list/table are here: https://sketch.cloud/s/R9k28/a/rWLoQP however they don't demonstrate every single example that we have so I think it would be great for me to sit down with a designer and go through all the examples that we have and make sure we're consistent across design and dev.

@gdoyle1 added "update symbol library" label. I'm going to add 30 minutes on your calendar so that I can help you update the library!

nice!!

Good job, LGTM!

@mattnolting @mcoker fixed the ::before border

Perfect! LGTM

🎉 This PR is included in version 2.33.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gdoyle1 added "update symbol library" label. I'm going to add 30 minutes on your calendar so that I can help you update the library!

Ah great thanks! Talk to you Friday about it @christiemolloy

# 2019.08 release notes (2019-10-01) Packages released: - @patternfly/patternfly@2.x ## Components - **Charts:** - Adjust padding for pie and donut charts ([#2247](#2247)) - Set mix-blend-mode for better color contrast ([#2239](#2239)) - Update area chart opacity ([#2233](#2233)) - **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260)) - **Data list:** Make data list borders consistent with table ([#2289](#2289)) - **Data toolbar:** - Updated clear button mods ([#2248](#2248)) - Added in examples for expandable ([#2273](#2273)) - **Flex layout:** Wrapped flex items, update css ([#2214](#2214)) - **Wizard:** - Re-enabled wizard modal demos ([#2259](#2259)) - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296)) - **Navigation:** Added styling updates to dark nav ([#2283](#2283)) - **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264)) - **Pagination:** Added compact variation ([#2275](#2275)) - **Radio:** Updated the radio component example to single components ([#2231](#2231)) - **Table:** - Fixed a11y issues in org documentation/html/table ([#2282](#2282)) - Added empty and loading state table demos ([#2254](#2254)) - **Tooltip:** Added text align left modifier ([#2284](#2284)) - **Select:** - Added typeahead form wrapper, udpated css ([#2255](#2255)) - Add top expanded example ([#2026](#2026)) - **Chip group:** Add overflow to group ([#2278](#2278)) - **Button:** Add control modifier ([#2005](#2005)) ## Other - **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263))

* Create 2019.08 release notes (2019-10-01) Adding new release notes * Update 2019.08 release notes (2019-10-01) # 2019.08 release notes (2019-10-01) Packages released: - @patternfly/patternfly@2.x ## Components - **Charts:** - Adjust padding for pie and donut charts ([#2247](#2247)) - Set mix-blend-mode for better color contrast ([#2239](#2239)) - Update area chart opacity ([#2233](#2233)) - **Copy to clipboard:** Wrapped code in pre which allows the code to preserve line-breaks and spaces and also applies styling such as the monospace font. ([#2260](#2260)) - **Data list:** Make data list borders consistent with table ([#2289](#2289)) - **Data toolbar:** - Updated clear button mods ([#2248](#2248)) - Added in examples for expandable ([#2273](#2273)) - **Flex layout:** Wrapped flex items, update css ([#2214](#2214)) - **Wizard:** - Re-enabled wizard modal demos ([#2259](#2259)) - Updated in page wizard demos to use dark sidebar/nav ([#2296](#2296)) - **Navigation:** Added styling updates to dark nav ([#2283](#2283)) - **Page:** Added ability to keep sidebar collapsed between sizes ([#2264](#2264)) - **Pagination:** Added compact variation ([#2275](#2275)) - **Radio:** Updated the radio component example to single components ([#2231](#2231)) - **Table:** - Fixed a11y issues in org documentation/html/table ([#2282](#2282)) - Added empty and loading state table demos ([#2254](#2254)) - **Tooltip:** Added text align left modifier ([#2284](#2284)) - **Select:** - Added typeahead form wrapper, udpated css ([#2255](#2255)) - Add top expanded example ([#2026](#2026)) - **Chip group:** Add overflow to group ([#2278](#2278)) - **Button:** Add control modifier ([#2005](#2005)) ## Other - **Shield:** Added missing components, missing var to brand docs js ([#2263](#2263)) * Rename 2019.08 release notes (2019-10-01) to 2019.08 release notes (2019-10-01).MD Added .md file name * Update 2019.08 release notes (2019-10-01).MD Co-Authored-By: Michael Coker <35148959+mcoker@users.noreply.github.com> * alphabetize components

christiemolloy added 3 commits September 13, 2019 16:46

fix(datalist): fix consistency between table

eee4929

fix(datalist): make it consistent

de537a6

fix(datalist): update

b220db0

christiemolloy requested a review from mcoker September 19, 2019 19:52

christiemolloy changed the title Issue 2185 Make data list consistent with table Sep 19, 2019

fix(datalist): make bottom border 0

c63e417

fix(datalist): fix bottom border

62eccec

mcoker reviewed Sep 24, 2019

View reviewed changes

mcoker requested changes Sep 24, 2019

View reviewed changes

fix(datalist): add declaration back in

d21984b

christiemolloy added the update symbol library label Sep 24, 2019

mattnolting self-requested a review September 24, 2019 20:26

mcoker approved these changes Sep 24, 2019

View reviewed changes

mattnolting approved these changes Sep 24, 2019

View reviewed changes

fix(datalist): fix before border

7f2ebf5

fix(datalist): add breakpoint

bc37e23

mattnolting self-requested a review September 25, 2019 14:15

mattnolting approved these changes Sep 25, 2019

View reviewed changes

mattnolting added the Ready to merge label Sep 25, 2019

christiemolloy mentioned this pull request Sep 25, 2019

Update variables from the Data List #2305

Closed

mcoker merged commit c19256a into patternfly:master Sep 25, 2019

redallen added the released label Sep 25, 2019

                 list-style-type: disc;
                 background-color: var(--pf-c-data-list--BackgroundColor);
                 border-top: var(--pf-c-data-list--BorderTopWidth) solid var(--pf-c-data-list--BorderTopColor);
-                border-bottom: var(--pf-c-data-list--BorderBottomWidth) solid var(--pf-c-data-list--BorderBottomColor);

Make data list consistent with table by christiemolloy · Pull Request #2289 · patternfly/patternfly · GitHub

Uh oh!

Make data list consistent with table - #2289

Make data list consistent with table #2289mcoker merged 8 commits intopatternfly:masterpatternfly/patternfly:masterfrom christiemolloy:issue-2185christiemolloy/patternfly-next:issue-2185Copy head branch name to clipboard

Conversation

christiemolloy commented Sep 19, 2019

Uh oh!

patternfly-build commented Sep 19, 2019

Uh oh!

mcoker commented Sep 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

table

data list

Uh oh!

christiemolloy commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcoker commented Sep 24, 2019

Uh oh!

christiemolloy commented Sep 24, 2019

Uh oh!

mcoker Sep 24, 2019

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker commented Sep 24, 2019

Uh oh!

christiemolloy commented Sep 24, 2019

Uh oh!

christiemolloy commented Sep 24, 2019

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

mattnolting left a comment

Choose a reason for hiding this comment

Uh oh!

christiemolloy commented Sep 25, 2019

Uh oh!

mattnolting left a comment

Choose a reason for hiding this comment

Uh oh!

redallen commented Sep 25, 2019

Uh oh!

gdoyle1 commented Sep 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Make data list consistent with table #2289
mcoker merged 8 commits into
patternfly:masterfrom
christiemolloy:issue-2185

mcoker commented Sep 23, 2019 •
edited
Loading

christiemolloy commented Sep 24, 2019 •
edited
Loading

gdoyle1 commented Sep 25, 2019 •
edited
Loading