FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39793: use the same domain on make_msgid tests by isidentical · Pull Request #18698 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-39793: use the same domain on make_msgid tests - #18698

Merged
akuchling merged 2 commits into
python:masterfrom
isidentical:bpo-39793
Apr 16, 2020
ConversationCommits (2)ChecksFiles changed
Merged

bpo-39793: use the same domain on make_msgid tests#18698
akuchling merged 2 commits into
python:masterfrom
isidentical:bpo-39793

Conversation

isidentical commented Feb 29, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

isidentical requested a review from a team as a code owner February 29, 2020 09:59
bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Feb 29, 2020

codecov Bot commented Feb 29, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #18698 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #18698     +/-   ##
=========================================
  Coverage   82.13%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      589974   584604   -5370     
  Branches    44484    44484             
=========================================
- Hits       484572   480164   -4408     
+ Misses      95750    94794    -956     
+ Partials     9652     9646      -6
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
... and 332 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc04a05...4e01533. Read the comment docs.

akuchling suggested changes Mar 5, 2020
View reviewed changes
Comment thread Lib/test/test_email/test_email.py

bedevere-bot commented Mar 5, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

isidentical commented Mar 5, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented Mar 5, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@akuchling: please review the changes made to this pull request.

bedevere-bot requested a review from akuchling March 5, 2020 17:41

akuchling commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

@python/email-team -- do you want to veto this PR? Otherwise I'll go ahead and merge it.

isidentical commented Mar 31, 2020

Copy link
Copy Markdown
Member Author

@akuchling no objection so far, 12 days.

akuchling merged commit 5565c30 into python:master Apr 16, 2020

bedevere-bot commented Apr 16, 2020

Copy link
Copy Markdown

@akuchling: Please replace # with GH- in the commit message next time. Thanks!

miss-islington commented Apr 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2020
bpo-39793: use the same domain on make_msgid tests (pythonGH-18698)
f925795 
* bpo-39793: use same domain on make_msgid tests

* apply suggestions
(cherry picked from commit 5565c30)

Co-authored-by: Batuhan Taşkaya <batuhanosmantaskaya@gmail.com>

bedevere-bot commented Apr 16, 2020

Copy link
Copy Markdown

GH-19554 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2020
bpo-39793: use the same domain on make_msgid tests (pythonGH-18698)
73c434a 
* bpo-39793: use same domain on make_msgid tests

* apply suggestions
(cherry picked from commit 5565c30)

Co-authored-by: Batuhan Taşkaya <batuhanosmantaskaya@gmail.com>

bedevere-bot commented Apr 16, 2020

Copy link
Copy Markdown

GH-19555 is a backport of this pull request to the 3.7 branch.

akuchling pushed a commit that referenced this pull request Apr 16, 2020
bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19554)
ccf30e9 
(cherry picked from commit 5565c30)

Co-authored-by: Batuhan Taşkaya <batuhanosmantaskaya@gmail.com>
akuchling pushed a commit that referenced this pull request Apr 16, 2020
bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19555)
cd09d7e 
(cherry picked from commit 5565c30)

Co-authored-by: Batuhan Taşkaya <batuhanosmantaskaya@gmail.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 29, 2020
Merge branch 'master' into bpo-26543
e4d193d 
* master: (1985 commits)
  bpo-40179: Fix translation of #elif in Argument Clinic (pythonGH-19364)
  bpo-35967: Skip test with `uname -p` on Android (pythonGH-19577)
  bpo-40257: Improve help for the typing module (pythonGH-19546)
  Fix two typos in multiprocessing (pythonGH-19571)
  bpo-40286: Use random.randbytes() in tests (pythonGH-19575)
  bpo-40286: Makes simpler the relation between randbytes() and getrandbits() (pythonGH-19574)
  bpo-39894: Route calls from pathlib.Path.samefile() to os.stat() via the path accessor (pythonGH-18836)
  bpo-39897: Remove needless `Path(self.parent)` call, which makes `is_mount()` misbehave in `Path` subclasses. (pythonGH-18839)
  bpo-40282: Allow random.getrandbits(0) (pythonGH-19539)
  bpo-40302: UTF-32 encoder SWAB4() macro use a|b rather than a+b (pythonGH-19572)
  bpo-40302: Replace PY_INT64_T with int64_t (pythonGH-19573)
  bpo-40286: Add randbytes() method to random.Random (pythonGH-19527)
  bpo-39901: Move `pathlib.Path.owner()` and `group()` implementations into the path accessor. (pythonGH-18844)
  bpo-40300: Allow empty logging.Formatter.default_msec_format. (pythonGH-19551)
  bpo-40302: Add pycore_byteswap.h header file (pythonGH-19552)
  bpo-40287: Fix SpooledTemporaryFile.seek() return value (pythonGH-19540)
  Minor modernization and readability improvement to the tokenizer example (pythonGH-19558)
  bpo-40294: Fix _asyncio when module is loaded/unloaded multiple times (pythonGH-19542)
  Fix parameter names in assertIn() docs (pythonGH-18829)
  bpo-39793: use the same domain on make_msgid tests (python#18698)
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
akuchling akuchling approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL