Repository navigation
bpo-40257: Improve help for the typing module - #19546
Merged
serhiy-storchaka merged 4 commits intoApr 18, 2020
Merged
serhiy-storchaka merged 4 commits into
serhiy-storchaka merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* Show docstring for special forms. * Show docstring for special generic aliases. * Show documentation for __origin__ for generic aliases.
gvanrossum
approved these changes
Apr 16, 2020
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me. But let's see what @ilevkivskyi thinks.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Playing with this, I noticed that pydoc.doc(Any) prints output that doesn't end in a \n. Is that expected? (I really don't know anything about pydoc.) |
Sorry, something went wrong.
ilevkivskyi
approved these changes
Apr 16, 2020
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! Looks good, I have just one optional question.
Sorry, something went wrong.
Comment thread
Lib/typing.py
Outdated
|
|
||
| @__doc__.setter | ||
| def __doc__(self, value): | ||
| self._doc = value |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Do we need this to be settable? If possible I would keep it read-only, but it is not very important.
Sorry, something went wrong.
gvanrossum
approved these changes
Apr 18, 2020
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
May 29, 2020
* master: (1985 commits) bpo-40179: Fix translation of #elif in Argument Clinic (pythonGH-19364) bpo-35967: Skip test with `uname -p` on Android (pythonGH-19577) bpo-40257: Improve help for the typing module (pythonGH-19546) Fix two typos in multiprocessing (pythonGH-19571) bpo-40286: Use random.randbytes() in tests (pythonGH-19575) bpo-40286: Makes simpler the relation between randbytes() and getrandbits() (pythonGH-19574) bpo-39894: Route calls from pathlib.Path.samefile() to os.stat() via the path accessor (pythonGH-18836) bpo-39897: Remove needless `Path(self.parent)` call, which makes `is_mount()` misbehave in `Path` subclasses. (pythonGH-18839) bpo-40282: Allow random.getrandbits(0) (pythonGH-19539) bpo-40302: UTF-32 encoder SWAB4() macro use a|b rather than a+b (pythonGH-19572) bpo-40302: Replace PY_INT64_T with int64_t (pythonGH-19573) bpo-40286: Add randbytes() method to random.Random (pythonGH-19527) bpo-39901: Move `pathlib.Path.owner()` and `group()` implementations into the path accessor. (pythonGH-18844) bpo-40300: Allow empty logging.Formatter.default_msec_format. (pythonGH-19551) bpo-40302: Add pycore_byteswap.h header file (pythonGH-19552) bpo-40287: Fix SpooledTemporaryFile.seek() return value (pythonGH-19540) Minor modernization and readability improvement to the tokenizer example (pythonGH-19558) bpo-40294: Fix _asyncio when module is loaded/unloaded multiple times (pythonGH-19542) Fix parameter names in assertIn() docs (pythonGH-18829) bpo-39793: use the same domain on make_msgid tests (python#18698) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40257