bpo-40287: Fix SpooledTemporaryFile.seek() return value by methane · Pull Request #19540 · python/cpython · GitHub

https://bugs.python.org/issue40287

Are you going to submit a backported patch for 3.8/3.7 as the bug?
if not, don't we have to add to the documentation as Changed in version 3.9:?

Are you going to submit a backported patch for 3.8/3.7 as the bug?

Yes. I think this is a bug and safe enough to backport.

Thanks for the PR @methane. The changes LGTM; I just have a minor suggestion regarding the Misc/NEWS entry.

Suggested change

      
            Fixed ``SpooledTemporaryFile.seek()`` did not return the position.
          
            Fixed ``SpooledTemporaryFile.seek()`` to return the position instead of
          
            ``None``.

Grammar fix and slight elaboration on the change made.

slight elaboration on the change made.

While return (including implicit return) and return None has the same behavior,
"return None intentionally" is different from "return nothing (but None actually)" for human.

In this case, returned None didn't have any meaning. So I don't want to mention about None.

Hmm, good point. I suppose my thoughts were that if I were to read this news entry, I might ask "what did it do previously?". But in this case, the change was probably straightforward enough that they could simply look at the source.

LGTM

@methane
By the way, Can we add the unit test for the future regression?
https://github.com/python/cpython/blob/master/Lib/test/test_tempfile.py

Unittest

@methane lgtm :)

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <songofacandy@gmail.com>

GH-19566 is a backport of this pull request to the 3.8 branch.

GH-19567 is a backport of this pull request to the 3.7 branch.

It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <songofacandy@gmail.com>

* master: (1985 commits) bpo-40179: Fix translation of #elif in Argument Clinic (pythonGH-19364) bpo-35967: Skip test with `uname -p` on Android (pythonGH-19577) bpo-40257: Improve help for the typing module (pythonGH-19546) Fix two typos in multiprocessing (pythonGH-19571) bpo-40286: Use random.randbytes() in tests (pythonGH-19575) bpo-40286: Makes simpler the relation between randbytes() and getrandbits() (pythonGH-19574) bpo-39894: Route calls from pathlib.Path.samefile() to os.stat() via the path accessor (pythonGH-18836) bpo-39897: Remove needless `Path(self.parent)` call, which makes `is_mount()` misbehave in `Path` subclasses. (pythonGH-18839) bpo-40282: Allow random.getrandbits(0) (pythonGH-19539) bpo-40302: UTF-32 encoder SWAB4() macro use a|b rather than a+b (pythonGH-19572) bpo-40302: Replace PY_INT64_T with int64_t (pythonGH-19573) bpo-40286: Add randbytes() method to random.Random (pythonGH-19527) bpo-39901: Move `pathlib.Path.owner()` and `group()` implementations into the path accessor. (pythonGH-18844) bpo-40300: Allow empty logging.Formatter.default_msec_format. (pythonGH-19551) bpo-40302: Add pycore_byteswap.h header file (pythonGH-19552) bpo-40287: Fix SpooledTemporaryFile.seek() return value (pythonGH-19540) Minor modernization and readability improvement to the tokenizer example (pythonGH-19558) bpo-40294: Fix _asyncio when module is loaded/unloaded multiple times (pythonGH-19542) Fix parameter names in assertIn() docs (pythonGH-18829) bpo-39793: use the same domain on make_msgid tests (python#18698) ...

methane added 2 commits April 15, 2020 16:56

bpo-40287: Fix SpooledTemporaryFile.seek() return value

235ee75

Add news entry

6aaa9cd

the-knights-who-say-ni added the CLA signed label Apr 15, 2020

bedevere-bot added the awaiting core review label Apr 15, 2020

corona10 reviewed Apr 15, 2020

View reviewed changes

methane added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Apr 16, 2020

aeros approved these changes Apr 16, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Apr 16, 2020

Update 2020-04-15-17-21-48.bpo-40287.-mkEJH.rst

a5a62da

corona10 previously approved these changes Apr 16, 2020

View reviewed changes

check return value

fcbaedf

corona10 approved these changes Apr 17, 2020

View reviewed changes

methane merged commit 485e715 into python:master Apr 17, 2020

methane deleted the bpo40287 branch April 17, 2020 06:56

bedevere-bot removed the awaiting merge label Apr 17, 2020

bedevere-bot removed the needs backport to 3.8 label Apr 17, 2020

bedevere-bot removed the needs backport to 3.7 label Apr 17, 2020

miss-islington added a commit that referenced this pull request Apr 17, 2020

bpo-40287 : Fix SpooledTemporaryFile.seek() return value (GH-19540 )

11ae7d0

It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <songofacandy@gmail.com>

miss-islington added a commit that referenced this pull request Apr 17, 2020

bpo-40287 : Fix SpooledTemporaryFile.seek() return value (GH-19540 )

9796fe8

It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <songofacandy@gmail.com>

coderabbitai Bot mentioned this pull request Aug 20, 2026

docs: add v1.2 security review, performance review, and roadmap badry-dev/json-table-tool#4

Merged

bpo-40287: Fix SpooledTemporaryFile.seek() return value by methane · Pull Request #19540 · python/cpython · GitHub

Repository navigation

bpo-40287: Fix SpooledTemporaryFile.seek() return value - #19540

bpo-40287: Fix SpooledTemporaryFile.seek() return value#19540
methane merged 4 commits into
python:masterfrom
methane:bpo40287

methane commented Apr 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

corona10 left a comment

Uh oh!

methane commented Apr 16, 2020

Uh oh!

aeros left a comment

Uh oh!

aeros Apr 16, 2020

Uh oh!

methane Apr 16, 2020

Uh oh!

aeros Apr 16, 2020

Uh oh!

corona10 left a comment

Uh oh!

corona10 commented Apr 16, 2020

Uh oh!

corona10 left a comment

Uh oh!

miss-islington commented Apr 17, 2020

Uh oh!

bedevere-bot commented Apr 17, 2020

Uh oh!

bedevere-bot commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -0,0 +1 @@
		Fixed ``SpooledTemporaryFile.seek()`` did not return the position.

	Fixed ``SpooledTemporaryFile.seek()`` did not return the position.
	Fixed ``SpooledTemporaryFile.seek()`` to return the position instead of
	``None``.

bpo-40287: Fix SpooledTemporaryFile.seek() return value by methane · Pull Request #19540 · python/cpython · GitHub

Repository navigation

bpo-40287: Fix SpooledTemporaryFile.seek() return value - #19540

bpo-40287: Fix SpooledTemporaryFile.seek() return value#19540methane merged 4 commits intopython:masterpython/cpython:masterfrom methane:bpo40287methane/cpython:bpo40287Copy head branch name to clipboard

Conversation

methane commented Apr 15, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

methane commented Apr 16, 2020

Uh oh!

aeros left a comment

Choose a reason for hiding this comment

Uh oh!

aeros Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

methane Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

aeros Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

corona10 commented Apr 16, 2020

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Apr 17, 2020

Uh oh!

bedevere-bot commented Apr 17, 2020

Uh oh!

bedevere-bot commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bpo-40287: Fix SpooledTemporaryFile.seek() return value#19540
methane merged 4 commits into
python:masterfrom
methane:bpo40287

methane commented Apr 15, 2020 •
edited by bedevere-bot
Loading