Repository navigation
Handle unknown error codes gracefully - #1016
Merged
rytilahti merged 2 commits intoJun 27, 2024
Merged
rytilahti merged 2 commits into
rytilahti merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1016 +/- ##
==========================================
+ Coverage 91.20% 91.22% +0.01%
==========================================
Files 84 84
Lines 5627 5638 +11
Branches 1374 1374
==========================================
+ Hits 5132 5143 +11
Misses 384 384
Partials 111 111 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
sdb9696
requested changes
Jun 26, 2024
sdb9696
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good but this should also be implemented in aestransport
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Ohh, I thought that this would be only above the transport layer, but I see that it also has some error handling. I'll look into that, thanks for the review! |
Sorry, something went wrong.
…icate its internal use
Copy link
Copy Markdown
Member
Author
|
Added for aestransport & renamed the error to indicate that it's our internal error. |
Sorry, something went wrong.
sdb9696
approved these changes
Jun 26, 2024
sdb9696
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Merged
sdb9696
added a commit
that referenced
this pull request
Jul 1, 2024
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696) - Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti) - Update light transition module to work with child devices [\#1017](#1017) (@sdb9696) - Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696) - Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
Makes unknown error codes to be reported through KasaException which may be recoverable in some cases (i.e., a single command failing in the multi request). Related to home-assistant/core#118446
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696) - Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti) - Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696) - Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696) - Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes unknown error codes to be reported through KasaException which may be recoverable in some cases (i.e., a single command failing in the multi request).
Related to home-assistant/core#118446