Repository navigation
Update light transition module to work with child devices - #1017
Merged
sdb9696 merged 6 commits intoJun 27, 2024
Merged
sdb9696 merged 6 commits into
sdb9696 merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 91.22% 91.33% +0.11%
==========================================
Files 84 84
Lines 5638 5657 +19
Branches 1374 1371 -3
==========================================
+ Hits 5143 5167 +24
+ Misses 384 382 -2
+ Partials 111 108 -3 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
rytilahti
requested changes
Jun 26, 2024
Comment thread
kasa/feature.py
Comment thread
kasa/tests/device_fixtures.py
Comment thread
kasa/tests/discovery_fixtures.py
Comment thread
kasa/tests/fakeprotocol_smart.py
Comment thread
kasa/tests/fixtureinfo.py
Comment thread
kasa/tests/test_device_factory.py
Comment thread
kasa/smart/modules/lighttransition.py
Outdated
rytilahti
reviewed
Jun 26, 2024
Comment thread
kasa/smart/modules/lighttransition.py
Outdated
rytilahti
reviewed
Jun 27, 2024
Comment thread
kasa/tests/smart/modules/test_lighttransition.py
Outdated
rytilahti
reviewed
Jun 27, 2024
Comment thread
kasa/smart/smartchilddevice.py
rytilahti
approved these changes
Jun 27, 2024
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, tested to work with v1 L920 and V3 L530!
Sorry, something went wrong.
Merged
sdb9696
added a commit
that referenced
this pull request
Jul 1, 2024
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696) - Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti) - Update light transition module to work with child devices [\#1017](#1017) (@sdb9696) - Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696) - Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
…a#1017) Fixes module to work with child devices, i.e. ks240 Interrogates the data to see whether maximums are available. Fixes a bug whereby setting a duration while the feature is not enabled does not actually enable it.
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696) - Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti) - Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696) - Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696) - Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains a few fixes and improvements for the LightTransition module:
N.B. the ks240 has component version 2 but does support the maximum values