Repository navigation
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 84 84
Lines 5657 5662 +5
Branches 1371 1374 +3
=======================================
+ Hits 5167 5172 +5
Misses 382 382
Partials 108 108 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This looks good and is our first usage of a python 3.9 feature now we've dropped 3.8 support. Ready for review? |
Sorry, something went wrong.
bdraco
marked this pull request as ready for review
June 29, 2024 12:18
sdb9696
approved these changes
Jun 30, 2024
Merged
sdb9696
added a commit
that referenced
this pull request
Jul 1, 2024
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696) - Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti) - Update light transition module to work with child devices [\#1017](#1017) (@sdb9696) - Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696) - Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
Uses the python 3.9 cache feature to improve performance of error code creation
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01) [Full Changelog](python-kasa/python-kasa@0.7.0.1...0.7.0.2) This patch release fixes some minor issues found out during testing against all new homeassistant platforms. **Fixed bugs:** - Disable multi-request on unknown errors [\python-kasa#1027](python-kasa#1027) (@sdb9696) - Disable multi requests on json decode error during multi-request [\python-kasa#1025](python-kasa#1025) (@sdb9696) - Fix changing brightness when effect is active [\python-kasa#1019](python-kasa#1019) (@rytilahti) - Update light transition module to work with child devices [\python-kasa#1017](python-kasa#1017) (@sdb9696) - Handle unknown error codes gracefully [\python-kasa#1016](python-kasa#1016) (@rytilahti) **Project maintenance:** - Make parent attribute on device consistent across iot and smart [\python-kasa#1023](python-kasa#1023) (@sdb9696) - Cache SmartErrorCode creation [\python-kasa#1022](python-kasa#1022) (@bdraco)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the __call__ and __new__ overhead to create the singleton by caching the creation. Since we never overload methods or subclass these, we can avoid all the complexity most of the time. This is a tiny optimization.
before:
after