FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add module.device to the public api by sdb9696 · Pull Request #1478 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Add module.device to the public api - #1478

Merged
rytilahti merged 3 commits into
masterfrom
feat/module_device
Jan 29, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Add module.device to the public api#1478
rytilahti merged 3 commits into
masterfrom
feat/module_device

Conversation

sdb9696 commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

sdb9696 mentioned this pull request Jan 23, 2025
Merged

codecov Bot commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (09e73fa) to head (a99c14b).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1478   +/-   ##
=======================================
  Coverage   92.64%   92.65%           
=======================================
  Files         149      149           
  Lines        9428     9431    +3     
  Branches      957      957           
=======================================
+ Hits         8735     8738    +3     
  Misses        497      497           
  Partials      196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rytilahti requested changes Jan 23, 2025
View reviewed changes

rytilahti left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but this PR should also convert the existing code to use this instead of accessing module privates.

rytilahti added the maintenance Project improvements and maintenance label Jan 23, 2025
rytilahti reviewed Jan 23, 2025
View reviewed changes
Comment thread kasa/module.py Outdated

sdb9696 commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

LGTM, but this PR should also convert the existing code to use this instead of accessing module privates.

If a module accesses its own private members I think that is fine. This change is useful for tests where the module comes from a child etc.

sdb9696 commented Jan 29, 2025

Copy link
Copy Markdown
Contributor Author

LGTM, but this PR should also convert the existing code to use this instead of accessing module privates.

Any code outside of module derived classes now updated to use the public property (only affects tests)

sdb9696 added this to the 0.10.1 milestone Jan 29, 2025
sdb9696 requested a review from rytilahti January 29, 2025 16:23
rytilahti approved these changes Jan 29, 2025
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great, thanks @sdb9696!

rytilahti merged commit ebd370d into master Jan 29, 2025
rytilahti deleted the feat/module_device branch January 29, 2025 18:49
sdb9696 mentioned this pull request Jan 31, 2025
Merged
sdb9696 added a commit that referenced this pull request Feb 2, 2025
Prepare 0.10.1 (#1494)
cbab40a 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\#1488](#1488) (@rytilahti)
- Add Dimmer Configuration Support [\#1484](#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\#1491](#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\#1489](#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\#1478](#1478) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
Add module.device to the public api (python-kasa#1478)
f80a63a
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
Prepare 0.10.1 (python-kasa#1494)
1c6ceb5 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
Add module.device to the public api (python-kasa#1478)
a5ff5b2
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
Prepare 0.10.1 (python-kasa#1494)
9b22056 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
Add module.device to the public api (python-kasa#1478)
338f1f9
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
Prepare 0.10.1 (python-kasa#1494)
092771d 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
Add module.device to the public api (python-kasa#1478)
7e232cf
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
Prepare 0.10.1 (python-kasa#1494)
15a8bf8 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Add module.device to the public api (python-kasa#1478)
1e41560
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Prepare 0.10.1 (python-kasa#1494)
179d5e9 
## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

maintenance Project improvements and maintenance

Projects

None yet

Milestone

0.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL