Add Dimmer Configuration Support by ryenitcher · Pull Request #1484 · python-kasa/python-kasa · GitHub

Add: Support for configuring minimum dimming level.
Add: Support for configuring dimmer ramp rate.
Add: Support for configuring dimmer gentle fade time.
Add: Support for configuring dimmper fade time.

Hopefully breaking out the dimmer configuration into a feature from the module is acceptable.

I've tested this against an KS220, and it appears to work well, but I can look into adding proper tests for this if the change seems reasonable to you.

This should cover #1464

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (09e73fa) to head (f010a3b).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1484      +/-   ##
==========================================
+ Coverage   92.64%   92.71%   +0.06%     
==========================================
  Files         149      150       +1     
  Lines        9428     9524      +96     
  Branches      957      968      +11     
==========================================
+ Hits         8735     8830      +95     
+ Misses        497      496       -1     
- Partials      196      198       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Looks really great and it's nice to see also older devices getting some love, thanks @ryenitcher! 💯

I added some comments (which likely apply for all these settings) inline, let me know if you think those changes make sense or not. On tests, it would be great to have some, either test_motion.py or test_ambientlight.py could be a good starting point.

Suggested change

      
                    if (min < 0) or (min > 51):
          
                    if min < 0 or min > 51:

Is it really up to 51 and not 50? In any case, no need for parentheses here.

Yeah if you use the app to set the dimmer trim to max, it sets the value to 51, which surprised me as well. The API rejects 52 as a value though, so it has to end on 51. Perhaps there is a special bypass mode on the triac or something for no dimming, and that's a special value used to denote that?

Could be something special indeed, but we can keep it as it is and adjust when someone chimes in with an issue report :)

Could be worth adding a small comment here about the tested app behaviour.

- Add: Support for configuring minimum dimming level. - Add: Support for configuring dimmer ramp rate. - Add: Support for configuring dimmer gentle fade time. - Add: Support for configuring dimmper fade time.

- Fix: Return time values as `timedelta` instead of `int`. - Fix: Move constants to top of file. - Fix: Correct feature types. - Fix: Expose range of bounded features.

- Add: Tests for IOT Dimmer feature.

I'm not sure if it's worth writing a test for this line?

I doubt it will ever be triggered, and even then all it does its immediately return?

Just some minor style-related nitpicks but this looks otherwise good to go, thanks @ryenitcher!

Looks really great and it's nice to see also older devices getting some love, thanks @ryenitcher! 💯

It looks like the KS240 might be the only “new” dimmer so far (from searching the fixture files), but it looks like the config layout for the IOT version is roughly the same. I can copy over support to IOT in a follow up PR if that works. The new matter dimmer (KS225) might also be an IOT dimmer, but I don’t currently have one to test against.

- Fix: Correct inline comment formatting. - Fix: Remove un-needed check for `get_dimmer_parameters` on dimmers. - Fix: Remove extra newline from docstring summaries.

I think this PR should now be ready to go.

I've opened #1495 in draft status for calibration support on the SMART devices.

LGTM, thanks @ryenitcher! 🎉

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\#1488](#1488) (@rytilahti) - Add Dimmer Configuration Support [\#1484](#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\#1491](#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\#1489](#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\#1478](#1478) (@sdb9696)

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02) [Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1) **Release summary:** Small patch release for bugfixes **Implemented enhancements:** - dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti) - Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher) **Fixed bugs:** - Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696) - Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696) **Project maintenance:** - Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti linked an issue Jan 25, 2025 that may be closed by this pull request

Dimmer Calibration? NOT Presets #1464

Closed

rytilahti added the enhancement New feature or request label Jan 26, 2025

rytilahti requested changes Jan 26, 2025

View reviewed changes

ryenitcher added 2 commits January 26, 2025 13:46

Add Dimmer Configuration Support

9b94eab

- Add: Support for configuring minimum dimming level. - Add: Support for configuring dimmer ramp rate. - Add: Support for configuring dimmer gentle fade time. - Add: Support for configuring dimmper fade time.

Apply Suggested Changes

cdbac94

- Fix: Return time values as `timedelta` instead of `int`. - Fix: Move constants to top of file. - Fix: Correct feature types. - Fix: Expose range of bounded features.

ryenitcher force-pushed the dev-dimcal branch from 77299dd to cdbac94 Compare January 26, 2025 20:46

Add IOT Dimmer Tests

535de3a

- Add: Tests for IOT Dimmer feature.

rytilahti approved these changes Jan 27, 2025

View reviewed changes

Formatting Corrections

f010a3b

- Fix: Correct inline comment formatting. - Fix: Remove un-needed check for `get_dimmer_parameters` on dimmers. - Fix: Remove extra newline from docstring summaries.

rytilahti approved these changes Feb 2, 2025

View reviewed changes

sdb9696 added this to the 0.10.1 milestone Feb 2, 2025

sdb9696 merged commit bff5409 into python-kasa:master Feb 2, 2025

sdb9696 mentioned this pull request Feb 2, 2025

Prepare 0.10.1 #1494

Merged

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025

Add Dimmer Configuration Support (python-kasa#1484 )

b77aad8

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025

Add Dimmer Configuration Support (python-kasa#1484 )

cf25597

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025

Add Dimmer Configuration Support (python-kasa#1484 )

aa627f7

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026

Add Dimmer Configuration Support (python-kasa#1484 )

dfdb363

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026

Add Dimmer Configuration Support (python-kasa#1484 )

24482b9

Add Dimmer Configuration Support by ryenitcher · Pull Request #1484 · python-kasa/python-kasa · GitHub

Repository navigation

Add Dimmer Configuration Support - #1484

Add Dimmer Configuration Support#1484sdb9696 merged 4 commits intopython-kasa:masterpython-kasa/python-kasa:masterfrom ryenitcher:dev-dimcalryenitcher/python-kasa:dev-dimcalCopy head branch name to clipboard

Conversation

ryenitcher commented Jan 25, 2025

Uh oh!

ryenitcher commented Jan 25, 2025

Uh oh!

ryenitcher commented Jan 25, 2025

Uh oh!

codecov Bot commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rytilahti Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

ryenitcher Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rytilahti Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

sdb9696 Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryenitcher commented Jan 26, 2025

Uh oh!

rytilahti left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryenitcher commented Jan 28, 2025

Uh oh!

ryenitcher commented Feb 1, 2025

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Dimmer Configuration Support#1484
sdb9696 merged 4 commits into
python-kasa:masterfrom
ryenitcher:dev-dimcal

codecov Bot commented Jan 25, 2025 •
edited
Loading

ryenitcher Jan 26, 2025 •
edited
Loading

rytilahti left a comment •
edited
Loading