FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

Add FeatureAttributes to smartcam Alarm by sdb9696 · Pull Request #1489 · python-kasa/python-kasa · GitHub

Repository navigation

Add FeatureAttributes to smartcam Alarm - #1489

Merged

sdb9696 merged 4 commits into

fix/smartcam_alarm

Jan 29, 2025

Merged

Add FeatureAttributes to smartcam Alarm#1489
sdb9696 merged 4 commits into
masterfrom
fix/smartcam_alarm

sdb9696 commented Jan 27, 2025 •
edited
Loading

Copy link Copy Markdown

Contributor

These were missed off in #1479. Testing with HA PR 136642 picked this up.

Adding a test case for this highlighted that the decorators currently lose the Annotated annotations which functools.wraps fixes.

Add FeatureAttributes to smartcam Alarm

a8fde52

sdb9696 added the bug Something isn't working label Jan 27, 2025

sdb9696 added this to the 0.10.1 milestone Jan 27, 2025

codecov Bot commented Jan 27, 2025 •
edited
Loading

Copy link Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (ebd370d) to head (5b25084).
Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   92.63%   92.64%   +0.01%     
==========================================
  Files         149      149              
  Lines        9434     9439       +5     
  Branches      958      958              
==========================================
+ Hits         8739     8745       +6     
+ Misses        498      496       -2     
- Partials      197      198       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdb9696 requested a review from rytilahti January 29, 2025 16:23

sdb9696 commented Jan 29, 2025

View reviewed changes

Comment thread kasa/interfaces/energy.py

sdb9696 commented Jan 29, 2025

View reviewed changes

Comment thread kasa/smart/smartmodule.py

    
                  """

                  async def _async_wrap(self: _T, *args: _P.args, **kwargs: _P.kwargs) -> dict:

                  @wraps(func)

sdb9696 Jan 29, 2025

Copy link Copy Markdown

Contributor Author

This was previously not working when using a decorator which the test cases highlighted. i.e. if using a decorator the type hints were not copied to the decorator function so get_feature would fail.

rytilahti approved these changes Jan 29, 2025

View reviewed changes

rytilahti left a comment

Copy link Copy Markdown

Member

Just a couple of readability nits, feel free to fix/merge as you wish.

Comment thread tests/test_common_modules.py

Comment thread tests/test_common_modules.py

Comment thread tests/test_common_modules.py

Comment thread tests/test_common_modules.py

sdb9696 and others added 3 commits January 29, 2025 19:26

Address code review suggestions

cc7bd03

Update tests/test_common_modules.py

fb2c12c

Co-authored-by: Teemu R. <tpr@iki.fi>

Merge branch 'master' into fix/smartcam_alarm

5b25084

sdb9696 enabled auto-merge (squash) January 29, 2025 19:29

sdb9696 merged commit 44c561b into master Jan 29, 2025

sdb9696 deleted the fix/smartcam_alarm branch January 29, 2025 19:32

sdb9696 mentioned this pull request Jan 31, 2025

Prepare 0.10.1 #1494

Merged

sdb9696 added a commit that referenced this pull request Feb 2, 2025

Prepare 0.10.1 (#1494 )

cbab40a

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\#1488](#1488) (@rytilahti)
- Add Dimmer Configuration Support [\#1484](#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\#1491](#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\#1489](#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\#1478](#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025

Add FeatureAttributes to smartcam Alarm (python-kasa#1489 )

56c7fac

Co-authored-by: Teemu R. <tpr@iki.fi>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025

Prepare 0.10.1 (python-kasa#1494 )

1c6ceb5

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025

Add FeatureAttributes to smartcam Alarm (python-kasa#1489 )

50a39ef

Co-authored-by: Teemu R. <tpr@iki.fi>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025

Prepare 0.10.1 (python-kasa#1494 )

9b22056

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025

Add FeatureAttributes to smartcam Alarm (python-kasa#1489 )

b2565b4

Co-authored-by: Teemu R. <tpr@iki.fi>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025

Prepare 0.10.1 (python-kasa#1494 )

092771d

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026

Add FeatureAttributes to smartcam Alarm (python-kasa#1489 )

f806d15

Co-authored-by: Teemu R. <tpr@iki.fi>

rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026

Prepare 0.10.1 (python-kasa#1494 )

15a8bf8

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026

Add FeatureAttributes to smartcam Alarm (python-kasa#1489 )

74dc5aa

Co-authored-by: Teemu R. <tpr@iki.fi>

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026

Prepare 0.10.1 (python-kasa#1494 )

179d5e9

## [0.10.1](https://github.com/python-kasa/python-kasa/tree/0.10.1) (2025-02-02)

[Full Changelog](python-kasa/python-kasa@0.10.0...0.10.1)

**Release summary:**

Small patch release for bugfixes

**Implemented enhancements:**

- dustbin\_mode: add 'off' mode for cleaner downstream impl [\python-kasa#1488](python-kasa#1488) (@rytilahti)
- Add Dimmer Configuration Support [\python-kasa#1484](python-kasa#1484) (@ryenitcher)

**Fixed bugs:**

- Do not return empty string for custom light effect name [\python-kasa#1491](python-kasa#1491) (@sdb9696)
- Add FeatureAttributes to smartcam Alarm [\python-kasa#1489](python-kasa#1489) (@sdb9696)

**Project maintenance:**

- Add module.device to the public api [\python-kasa#1478](python-kasa#1478) (@sdb9696)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

Milestone

0.10.1

Back | FazBrowse Home | New Git URL