Fix ESP32 Lowside Current Sense ADC2 init - #346
Merged
runger1101001 merged 1 commit intoNov 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: @nmscode
Copy link
Copy Markdown
Contributor
|
I have verified this fix on the ESP32 Pico Devkit M2 board that uses the ESP32-PICO-MINI-02. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks so much for finding and fixing this! ❤️ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug, where lowside sensing using the ADC2 triggered the correct adc conversion, but then tried reading ADC1, resulting in a WDT error.