refactor(plan): rename spawn env map - #452
Merged
wan9chi merged 1 commit intoJun 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Motivation: The serialized SpawnCommand env field was named all_envs, but it actually represents the env map passed to the spawned process after cache env filtering. That made it easy to confuse with the unfiltered command env context used by runner-aware APIs. Scope: Rename SpawnCommand::all_envs to spawn_envs, update execution call sites, clean local helper naming, and refresh plan snapshots for the serialized key. This PR is behavior-neutral. Verification: - cargo check -p vite_task_plan -p vite_task -p vite_task_bin - cargo test -p vite_task_plan envs::tests - cargo test -p vite_task_plan --test plan_snapshots
This was referenced Jun 13, 2026
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
wan9chi
marked this pull request as ready for review
June 13, 2026 17:17
Copy link
Copy Markdown
Member
Author
Merge activity |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The serialized SpawnCommand env field was named all_envs, but it actually represents the env map passed to the spawned process after cache env filtering. That made it easy to confuse with the unfiltered command env context used by runner-aware APIs.
Scope
Rename SpawnCommand::all_envs to spawn_envs, update execution call sites, clean local helper naming, and refresh plan snapshots for the serialized key. This PR is behavior-neutral.
Verification
cargo check -p vite_task_plan -p vite_task -p vite_task_bin
cargo test -p vite_task_plan envs::tests
cargo test -p vite_task_plan --test plan_snapshots