Default copy operations for grid_map_core types - #541
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This upstreams RoboStack downstream patch `patch/ros-rolling-grid-map-core.osx.patch`. Best-guess rationale: explicitly defaulting copy construction and assignment keeps BufferRegion and Polygon usable in containers on toolchains that are stricter around implicit special member generation with aligned Eigen types. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Copy link
Copy Markdown
Author
|
FYI @wep21 and @traversaro, this upstream PR comes from the RoboStack patch upstreaming tracker: RoboStack/robostack.github.io#16. Origin patch: RoboStack patch/ros-rolling-grid-map-core.osx.patch, authored by Daisuke Nishimatsu. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Tick the box to add this pull request to the merge queue (same as @mergifyio queue).
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: RoboStack patch/ros-rolling-grid-map-core.osx.patch, authored by Daisuke Nishimatsu.
Best-guess rationale: explicitly defaulting copy construction and assignment keeps BufferRegion and Polygon usable in containers on toolchains that are stricter around implicit special member generation with aligned Eigen types.