v20.14.0 proposal by marco-ippolito · Pull Request #53120 · nodejs/node · GitHub

2024-05-28, Version 20.14.0 'Iron' (LTS), @marco-ippolito

Notable Changes

[28d2baa17c] - src,permission: throw async errors on async APIs (Rafael Gonzaga) #52730
[77e2bf029a] - (SEMVER-MINOR) test_runner: support forced exit (Colin Ihrig) #52038

Commits

[e3ad05d8b0] - deps: V8: cherry-pick 500de8bd371b (Richard Lau) #52676
[053282e661] - deps: V8: backport c4be0a97f981 (Richard Lau) #52183
[200dadb879] - deps: V8: cherry-pick f8d5e576b814 (Richard Lau) #52183
[f5cd125e02] - deps: update googletest to fa6de7f (Node.js GitHub Bot) #52949
[bbbfd7f4e1] - deps: update corepack to 0.28.1 (Node.js GitHub Bot) #52946
[7ba30a57a6] - deps: update simdutf to 5.2.8 (Node.js GitHub Bot) #52727
[b21a480a28] - deps: update simdutf to 5.2.6 (Node.js GitHub Bot) #52727
[6cfad60d97] - deps: update googletest to 2d16ed0 (Node.js GitHub Bot) #51657
[34708d1429] - deps: update googletest to d83fee1 (Node.js GitHub Bot) #51657
[c1d3e558e8] - deps: update googletest to 5a37b51 (Node.js GitHub Bot) #51657
[69959d0fca] - deps: update googletest to 5197b1a (Node.js GitHub Bot) #51657
[c8305f6057] - deps: update googletest to eff443c (Node.js GitHub Bot) #51657
[760b788704] - deps: update googletest to c231e6f (Node.js GitHub Bot) #51657
[301541cc8f] - deps: update googletest to e4fdb87 (Node.js GitHub Bot) #51657
[981d57e401] - deps: update googletest to 5df0241 (Node.js GitHub Bot) #51657
[a1817f534d] - deps: update googletest to b75ecf1 (Node.js GitHub Bot) #51657
[42070ca189] - deps: update googletest to 4565741 (Node.js GitHub Bot) #51657
[edc3e5d056] - deps: update uvwasi to 0.0.21 (Node.js GitHub Bot) #52863
[26b1231ffb] - deps: upgrade npm to 10.7.0 (npm team) #52767
[e6d9fbece2] - doc: update process.versions properties (ishabi) #52736
[8c1f837c0a] - doc: remove mold use on mac for speeding up build (Cong Zhang) #52252
[d9c5114694] - doc: fix grammatical mistake (codershiba) #52808
[b350f435b7] - meta: add mailmap entry for legendecas (Chengzhong Wu) #52795
[61f9f12eff] - meta: bump actions/checkout from 4.1.1 to 4.1.4 (dependabot[bot]) #52787
[ac563667d6] - meta: bump github/codeql-action from 3.24.9 to 3.25.3 (dependabot[bot]) #52786
[70611d7924] - meta: bump actions/upload-artifact from 4.3.1 to 4.3.3 (dependabot[bot]) #52785
[30482ea273] - meta: bump actions/download-artifact from 4.1.4 to 4.1.7 (dependabot[bot]) #52784
[d1607cdebb] - meta: bump codecov/codecov-action from 4.1.1 to 4.3.1 (dependabot[bot]) #52783
[21f1b6bfc3] - meta: bump step-security/harden-runner from 2.7.0 to 2.7.1 (dependabot[bot]) #52782
[0c6019a222] - meta: standardize regex (Aviv Keller) #52693
[28d2baa17c] - src,permission: throw async errors on async APIs (Rafael Gonzaga) #52730
[cffd2cc0c9] - Revert "stream: revert fix cloned webstreams not being unref'd" (Marco Ippolito) #53144
[3dd96f1fab] - stream: implement TransformStream cleanup using "transformer.cancel" (Debadree Chatterjee) #50126
[8e7e778e01] - test: skip v8-updates/test-linux-perf (Michaël Zasso) #49639
[f8e18869e9] - test: replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
[a501860d63] - test_runner: don't await the same promise for each test (Colin Ihrig) #52185
[e2ae4367f4] - test_runner: run top level tests in a microtask (Colin Ihrig) #52092
[77e2bf029a] - (SEMVER-MINOR) test_runner: support forced exit (Colin Ihrig) #52038
[b7bc63565e] - test_runner: ignore todo flag when running suites (Colin Ihrig) #52117
[be587e3ae3] - test_runner: use paths for test locations (Colin Ihrig) #52010
[743281ab25] - test_runner: support source mapped test locations (Colin Ihrig) #52010
[4051316d95] - tools: update lint-md-dependencies to rollup@4.17.0 (Node.js GitHub Bot) #52729

Fixes: #49971 PR-URL: #50126 Backport-PR-URL: #52772 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Refs: v8/v8@e3e8ea5 PR-URL: #50115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Refs: #50079 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This commit adds support for source mapping test locations when the --enable-source-maps flag is present. Fixes: #51392 PR-URL: #52010 Backport-PR-URL: #52872 Fixes: #51610 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: #51610 PR-URL: #52010 Backport-PR-URL: #52872 Fixes: #51392 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #52767 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

PR-URL: #52693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.0 to 2.7.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@63c24ba...a4aa98b) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52782 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.1 to 4.3.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@c16abc2...5ecb98a) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52783 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.4 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@c850b93...65a9edc) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52784 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@5d5d22a...6546280) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52785 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.9 to 3.25.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@1b1aada...d39d31e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52786 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@b4ffde6...0ad4b8f) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #52787 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52795 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #52808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

PR-URL: #52863 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #51657 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #52727 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #52946 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #52949 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

I think you're just seeing flakes. This test didn't fail in https://ci.nodejs.org/job/node-test-pull-request/59440

I think you're just seeing flakes. This test didn't fail in https://ci.nodejs.org/job/node-test-pull-request/59440

Read too late, I'm having a lot of failing test on my backport too #53144
I'll give a try and if doesnt change I'll add it back, it's quite frustrating
Edit: it seems it actually made it less flaky

This reverts commit 8d20b64. PR-URL: #53144 Fixes: #53143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Notable changes: src,permission: * throw async errors on async APIs (Rafael Gonzaga) #52730 test_runner: * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 PR-URL: #53120

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6008/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6008/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6008/

CI: https://ci.nodejs.org/job/node-test-pull-request/59472/ 🟢
CITGM: https://ci.nodejs.org/job/citgm-smoker/3442/
(v20.13.0 CITGM) https://ci.nodejs.org/job/citgm-smoker/3428/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/6008/ 🟢
RELEASE-CI: https://ci-release.nodejs.org/job/iojs+release/10229/ 🟢

I see a few new failures compared to v20.13.0 in CITGM
PTAL @nodejs/releasers if you think it should be blocking or I can proceed

Can you please pull in #53034? This fixes a bad regression on Headers. Ref #53186 @QuiiBz.

Can you please pull in #53034? This fixes a bad regression on Headers. Ref #53186 @QuiiBz.

I have already started the release process, and according to policy it needs to stay in current for enough time before going to LTS. If it's not a problem I can release it in the next one (~2 weeks)

PR-URL: #53120

Notable changes: src,permission: * throw async errors on async APIs (Rafael Gonzaga) #52730 test_runner: * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 PR-URL: #53120

Refs: nodejs/node#53120

Notable changes: src,permission: * throw async errors on async APIs (Rafael Gonzaga) nodejs#52730 test_runner: * (SEMVER-MINOR) support forced exit (Colin Ihrig) nodejs#52038 PR-URL: nodejs#53120

debadree25 and others added 30 commits May 16, 2024 10:31

stream: implement TransformStream cleanup using "transformer.cancel"

3dd96f1

Fixes: #49971 PR-URL: #50126 Backport-PR-URL: #52772 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

test: replace always-opt flag with alway-turbofan

f8e1886

Refs: v8/v8@e3e8ea5 PR-URL: #50115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

test: skip v8-updates/test-linux-perf

8e7e778

Refs: #50079 PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

deps: upgrade npm to 10.7.0

26b1231

PR-URL: #52767 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

meta: standardize regex

0c6019a

PR-URL: #52693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

doc: fix grammatical mistake

d9c5114

PR-URL: #52808 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

deps: update uvwasi to 0.0.21

edc3e5d

PR-URL: #52863 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

deps: update simdutf to 5.2.6

b21a480

PR-URL: #52727 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

deps: update simdutf to 5.2.8

7ba30a5

PR-URL: #52727 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

deps: update googletest to fa6de7f

f5cd125

PR-URL: #52949 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

marco-ippolito force-pushed the v20.14.0-proposal branch from 911a9a7 to 4b2d1a0 Compare May 27, 2024 11:58

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024

This comment was marked as outdated.

Sign in to view

marco-ippolito added 2 commits May 27, 2024 22:21

Revert "stream: revert fix cloned webstreams not being unref'd"

cffd2cc

This reverts commit 8d20b64. PR-URL: #53144 Fixes: #53143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

2024-05-28, Version 20.14.0 'Iron' (LTS)

fe0f08a

Notable changes: src,permission: * throw async errors on async APIs (Rafael Gonzaga) #52730 test_runner: * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 PR-URL: #53120

marco-ippolito force-pushed the v20.14.0-proposal branch from 4b2d1a0 to fe0f08a Compare May 27, 2024 20:26

This comment was marked as outdated.

Sign in to view

richardlau approved these changes May 28, 2024

View reviewed changes

marco-ippolito merged commit fe0f08a into v20.x May 28, 2024

marco-ippolito deleted the v20.14.0-proposal branch May 28, 2024 16:32

marco-ippolito added a commit that referenced this pull request May 28, 2024

Working on v20.14.1

af614c5

PR-URL: #53120

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request May 28, 2024

Blog: v20.14.0 release post

5758eb8

Refs: nodejs/node#53120

github-merge-queue Bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 28, 2024

Blog: v20.14.0 release post (#6745 )

c9d5930

Refs: nodejs/node#53120

NashJames mentioned this pull request Jun 13, 2024

UnhandledPromiseRejectionWarning CFenner/MMM-AirQuality#57

Open

himself65 mentioned this pull request Sep 11, 2025

onRequest options are not handled properly in nodejs 20.13.1 better-auth/better-fetch#37

Closed

v20.14.0 proposal by marco-ippolito · Pull Request #53120 · nodejs/node · GitHub

Uh oh!

Uh oh!

v20.14.0 proposal - #53120

v20.14.0 proposal#53120marco-ippolito merged 43 commits intov20.xnodejs/node:v20.xfrom v20.14.0-proposalnodejs/node:v20.14.0-proposalCopy head branch name to clipboard

Conversation

marco-ippolito commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2024-05-28, Version 20.14.0 'Iron' (LTS), @marco-ippolito

Notable Changes

Commits

Uh oh!

targos commented May 27, 2024

Uh oh!

marco-ippolito commented May 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented May 27, 2024

Uh oh!

nodejs-github-bot commented May 27, 2024

Uh oh!

nodejs-github-bot commented May 27, 2024

Uh oh!

nodejs-github-bot commented May 28, 2024 • edited by marco-ippolito Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marco-ippolito commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marco-ippolito commented May 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

v20.14.0 proposal#53120
marco-ippolito merged 43 commits into
v20.xfrom
v20.14.0-proposal

marco-ippolito commented May 23, 2024 •
edited
Loading

marco-ippolito commented May 27, 2024 •
edited
Loading

nodejs-github-bot commented May 28, 2024 •
edited by marco-ippolito
Loading

marco-ippolito commented May 28, 2024 •
edited
Loading

mcollina commented May 28, 2024 •
edited
Loading