FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier by WolframAlph · Pull Request #131830 · python/cpython · GitHub

/ cpython Public

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier - #131830

Merged
Eclips4 merged 11 commits into
python:mainfrom
WolframAlph:rename-ast-opt
May 4, 2025
ConversationCommits (11)ChecksFiles changed
Merged

gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier#131830
Eclips4 merged 11 commits into
python:mainfrom
WolframAlph:rename-ast-opt

Conversation

WolframAlph commented Mar 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

WolframAlph marked this pull request as draft March 28, 2025 11:34
bedevere-app Bot mentioned this pull request Mar 28, 2025
Open
hugovk removed their request for review March 28, 2025 13:05
WolframAlph changed the title gh-126835: Rename ast_opt.c -> ast_process.c gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier Mar 28, 2025
picnixz approved these changes Mar 28, 2025
View reviewed changes
Comment thread Python/compile.c Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-03-28-15-06-55.gh-issue-126835.IpcMTn.rst
WolframAlph marked this pull request as ready for review March 28, 2025 14:35
WolframAlph requested a review from picnixz March 28, 2025 14:46

iritkatriel commented Mar 28, 2025

Copy link
Copy Markdown
Member

I'm not sure about the name ast_process. Seems to nonspecific. I don't have a better idea at the moment though.

WolframAlph commented Mar 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It does all kind of things. Optimizes format, removes docstrings, implements PEP 765, etc. I don't think there is good name for it to make it more specific.

WolframAlph commented Mar 28, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz Maybe you have better suggestion how to name it?

picnixz commented Mar 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

I think "ast_process" is fine but otherwise, something with AST_Transform as we're doing a transformation/checks on the AST. I feel there is a mix of AST optimization (real opts + docstrings eradication), a bit of AST processing/post-processing (PEP 765) and more. So process is fine IMO.

iritkatriel commented Mar 29, 2025

Copy link
Copy Markdown
Member

Maybe ast_preprocess. Preprocessing is a term you hear in compilers.

picnixz reviewed Mar 30, 2025
View reviewed changes

picnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, I think preprocess is better as it's before we compile (and compilers would call it a pre-processing step (e.g., C compilers would pre-process macros here and comments elimination; well optimization is not part of pre-processing and usually happens after but still before compilation I think?).

iritkatriel mentioned this pull request Mar 31, 2025
Closed

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

Eclips4 commented May 1, 2025

Copy link
Copy Markdown
Member

Hi @WolframAlph, are you still planning to work on this? We need to ship it soon since the feature freeze is approaching (May 6th).

Regarding the naming—I believe ast_preprocess is the most appropriate choice here.

WolframAlph commented May 1, 2025

Copy link
Copy Markdown
Contributor Author

Hi sorry for the delay, Ive been super busy last weeks. I will finish this ASAP.

AA-Turner reviewed May 4, 2025
View reviewed changes
Comment thread Python/ast_preprocess.c

WolframAlph commented May 4, 2025

Copy link
Copy Markdown
Contributor Author

@Eclips4 I've updated the PR. Please take a look.

Eclips4 approved these changes May 4, 2025
View reviewed changes

Eclips4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Eclips4 requested a review from picnixz May 4, 2025 12:35
Eclips4 merged commit 0a1fedb into python:main May 4, 2025
diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
Merge remote-tracking branch 'origin/main' into call-len
c03babc 
* origin/main: (111 commits)
  pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
  pythongh-131178: Add tests for `ast` command-line interface (python#133329)
  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
  pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
  pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
  pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
  pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
  pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
  pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
  pythongh-132457: make staticmethod and classmethod generic (python#132460)
  pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
  pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
  pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
  pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
  pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
  pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
  pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
  pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
  pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
  ...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-126835: Rename ast_opt.c to ast_preprocess.c and related…
53ed8c0 
… stuff after moving const folding to the peephole optimizier (python#131830)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
picnixz picnixz approved these changes
Eclips4 Eclips4 approved these changes
isidentical Awaiting requested review from isidentical isidentical is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL