gh-91048: Add filename and line number to external inspection routines - #133385
Merged
ambv merged 1 commit intoMay 4, 2025
Merged
gh-91048: Add filename and line number to external inspection routines#133385ambv merged 1 commit into
ambv merged 1 commit into
Conversation
pablogsal
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
May 4, 2025 16:29
1st1
reviewed
May 4, 2025
Comment thread
Modules/_remotedebuggingmodule.c
1st1
reviewed
May 4, 2025
Comment thread
Lib/test/test_external_inspection.py
Outdated
1st1
reviewed
May 4, 2025
1st1
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Merry x-mas! This is very cool. Left a couple of nit comments, looks great otherwise! <3
Sorry, something went wrong.
pablogsal
force-pushed
the
other
branch
4 times, most recently
from
e16d029 to
1312fb5
Compare
May 4, 2025 17:30
pablogsal
commented
May 4, 2025
Comment thread
Lib/asyncio/tools.py
| for tid, tname, awaited in tasks: | ||
| id2name[tid] = tname | ||
| for stack, parent_id in awaited: | ||
| stack = [elem[0] if isinstance(elem, tuple) else elem for elem in stack] |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@ambv This code just returns the fully qualified name. Play a bit with this and decide how we want to format this in the tool
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
No ref leaks: .venv ❯ sudo -E ./python.exe -m test test_external_inspection -R : Using random seed: 1218919259 Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 9.64 Run 1 test sequentially in a single process 0:00:00 load avg: 9.64 [1/1] test_external_inspection beginning 9 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more) 12345:6789 XX... .... 0:00:47 load avg: 6.37 [1/1] test_external_inspection passed in 47.2 sec == Tests result: SUCCESS == 1 test OK. Total duration: 47.2 sec Total tests: run=7 Total test files: run=1/1 Result: SUCCESS |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit eabbf17 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133385%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
…outines Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
diegorusso
added a commit
to diegorusso/cpython
that referenced
this pull request
May 4, 2025
* origin/main: (111 commits) pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385) pythongh-131178: Add tests for `ast` command-line interface (python#133329) Regenerate pcbuild.sln in Visual Studio 2022 (python#133394) pythongh-133042: disable HACL* HMAC on Emscripten (python#133064) pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387) pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946) pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388) pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830) pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368) pythongh-132457: make staticmethod and classmethod generic (python#132460) pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812) pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490) pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517) pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628) pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358) bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226) pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287) pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364) pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027) pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284) ...
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…outines (pythonGH-133385) Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.