gh-133351: Fix remote PDB's multi-line block tab completion - #133387
Merged
gaogaotiantian merged 1 commit intoMay 4, 2025
Merged
gh-133351: Fix remote PDB's multi-line block tab completion#133387gaogaotiantian merged 1 commit into
gaogaotiantian merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Provide extra context to the server so that it knows that we're requesting completions for a Python expression, rather than for PDB commands.
Comment thread
Lib/test/test_remote_pdb.py
Comment on lines
+535
to
+537
| """Test requesting tab completions at a (Pdb) continuation prompt.""" | ||
| # GIVEN | ||
| incoming = [ |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| """Test requesting tab completions at a (Pdb) continuation prompt.""" | |
| # GIVEN | |
| incoming = [ | |
| """Test requesting tab completions at a (Pdb) continuation prompt.""" | |
| incoming = [ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I kind of agree that #GIVEN is unnecessary here. However, that's consistent with other tests and it's not super important at this point. I do think in the future we should have a cleanup PR to clean these out. It's kind of redundent at this point.
Sorry, something went wrong.
gaogaotiantian
approved these changes
May 4, 2025
diegorusso
added a commit
to diegorusso/cpython
that referenced
this pull request
May 4, 2025
* origin/main: (111 commits) pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385) pythongh-131178: Add tests for `ast` command-line interface (python#133329) Regenerate pcbuild.sln in Visual Studio 2022 (python#133394) pythongh-133042: disable HACL* HMAC on Emscripten (python#133064) pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387) pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946) pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388) pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830) pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368) pythongh-132457: make staticmethod and classmethod generic (python#132460) pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812) pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490) pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517) pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628) pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358) bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226) pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287) pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364) pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027) pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284) ...
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide extra context to the server so that it knows that we're requesting completions for a Python expression, rather than for PDB commands.