FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133042: disable HACL* HMAC on Emscripten by picnixz · Pull Request #133064 · python/cpython · GitHub

/ cpython Public

gh-133042: disable HACL* HMAC on Emscripten - #133064

Merged
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/build/hacl-emscripten-133042
May 4, 2025
Merged

gh-133042: disable HACL* HMAC on Emscripten#133064
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/build/hacl-emscripten-133042

Conversation

picnixz commented Apr 27, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I don't want to hold the next beta and I don't know how we can easily make it work. I don't really want to revert #132438 as it solves an issue with freeze.py but we may eventually need to do it.

I plan to leave on Monday evening and I won't have access to my dev session until May 8th or something like that.

@hugovk Feel free to revert #132438 and #133012.
@hoodmane Feel free to take over this branch if you want. Also, please first confirm that disabling HACL* HMAC actually solves the issue (ISTM that it kinda works but I needed to run make manually because I had some issues with my system-wide Python that is too old for emcc & co).

picnixz commented Apr 27, 2025

Copy link
Copy Markdown
Member Author

@Lukasdoe Would this fix your issue?

Lukasdoe commented Apr 28, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

yes! I can confirm that this fixes the issue for me. Thx, well done :)

picnixz commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

Ok, I think it's better to just disable HACL* HMAC on Emscripten for now.

picnixz requested a review from hugovk May 4, 2025 17:06
picnixz merged commit 7b96701 into python:main May 4, 2025
picnixz deleted the fix/build/hacl-emscripten-133042 branch May 4, 2025 19:55

hoodmane commented May 4, 2025

Copy link
Copy Markdown
Contributor

Thanks @picnixz ! I'm not sure why I didn't see these notifications until just now. My GitHub notifications are a mess.

hoodmane commented May 4, 2025

Copy link
Copy Markdown
Contributor

I'll look into fixing this tomorrow.

diegorusso added a commit to diegorusso/cpython that referenced this pull request May 4, 2025
* origin/main: (111 commits)
  pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)
  pythongh-131178: Add tests for `ast` command-line interface (python#133329)
  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)
  pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)
  pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)
  pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)
  pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)
  pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)
  pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)
  pythongh-132457: make staticmethod and classmethod generic (python#132460)
  pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)
  pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)
  pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)
  pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)
  pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)
  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)
  pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)
  pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)
  pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)
  pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)
  ...
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL