Repository navigation
Fix SMARTCAM Time module and update tests - #1659
Merged
ZeliardM merged 16 commits intoJul 11, 2026
Merged
ZeliardM merged 16 commits into
ZeliardM merged 16 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR fixes the SmartCam Time module's set_time method to properly set the device time manually. The fix addresses three key issues: formatting local_time in UTC (not machine local time), removing microseconds from the timestamp format, and switching timing_mode from "ntp" to "manual" so devices accept manual time updates.
Changes:
- Fixed time formatting to use UTC without microseconds (format: 'YYYY-MM-DD HH:MM:SS')
- Added logic to set timing_mode to "manual" before updating clock_status (for devices that support it)
- Combined zone_id and timing_mode updates into a single API call for efficiency
- Added comprehensive unit tests covering all device types (cameras with timing_mode, hubs without timing_mode)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kasa/smartcam/modules/time.py | Rewrote set_time method to format time in UTC, set timing_mode to manual, and handle devices without timing_mode field |
| tests/test_common_modules.py | Added three comprehensive unit tests verifying UTC formatting, ZoneInfo handling, and H200 hub compatibility |
| tests/fakeprotocol_smartcam.py | Fixed variable shadowing issue by renaming nested 'section' variable to 'section_data' |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1659 +/- ##
=======================================
Coverage 93.21% 93.22%
=======================================
Files 157 157
Lines 9819 9829 +10
Branches 1005 1005
=======================================
+ Hits 9153 9163 +10
Misses 472 472
Partials 194 194 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Still working on the correct handling of the time zone information here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@rytilahti After further investigation, there appears no way for set_time to directly set the clock time on SMARTCAM devices. The set_time commands have been updated to correctly handle the timezone now and removed the sending of the seconds_from_1970 through the setTimezone function since it does nothing. Confirmed that this is all handled correctly now and that if the device is connected to the internet, it will pull the correct clock time via NTP. This should be good to go. |
Sorry, something went wrong.
rytilahti
reviewed
Mar 1, 2026
Comment thread
kasa/smartcam/modules/time.py
Outdated
Comment thread
tests/fakeprotocol_smartcam.py
Comment thread
tests/test_cli.py
Outdated
Comment thread
tests/test_common_modules.py
Outdated
Comment thread
tests/test_common_modules.py
Outdated
rytilahti
reviewed
Mar 2, 2026
Comment thread
tests/test_common_modules.py
Outdated
Copy link
Copy Markdown
Collaborator
Author
|
@rytilahti Yea, I forgot to push the commit, lol I re-worked it yet again. Give it another once over and let me know if this looks cleaner. I made the changes to the fake_smartcamprotocol.py for the multiple calls issue in the tests. Then, modified the tests correctly in the test_smartcamdevice.py, added instance checks in the test_cli.py and test_common_modules.py to handle the specifics that the smartcam/modules/time.py only sets the timezone and not the time and modified those tests accordingly and to catch the warning in the test_common_module.py. This looks cleaner to me now as well but let me know if I'm still missing it. |
Sorry, something went wrong.
ZeliardM
force-pushed
the
feature/device-time
branch
from
a1ea53b to
aef9930
Compare
March 4, 2026 18:33
rytilahti
requested changes
Apr 5, 2026
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
While I was reviewing (see the comments inline) and reading the PR description, I started to give second thoughts on whether we really want to do this, i.e., what's the use case?
If the reason for this is to allow changing the time zone, perhaps we should add an explicit method for doing that & just raise an exception about setting the time is not possible? This way, the interface would keep working on as expected which would keep our tests clean.
What do you think, @ZeliardM?
Sorry, something went wrong.
Comment thread
tests/test_common_modules.py
Outdated
Comment thread
tests/test_common_modules.py
Outdated
Comment thread
tests/test_common_modules.py
Outdated
Comment thread
kasa/smartcam/modules/time.py
Comment thread
tests/test_cli.py
Outdated
Copy link
Copy Markdown
Collaborator
Author
|
@rytilahti The reason I kept it all as the same paths as the other device types instead of separating out of an explicit method is because the other device types, IOT and SMART, all handle time and timezone under the same method and interface. SMARTCAM is the only one I have seen that cannot do an explicit set time function. So the modifications were to keep it all the same. Is what you're asking if I think we should separate timezone and time for all device types? Now, given that setting the time is not an option and the timezone should be NTP it really could be irrelevant to have this at all for SMARTCAM and just raise the error. Another thing is for people who do not use the App to set up the camera and set things up from scratch with python-kasa and don't allow the camera out to the internet then at that point NTP wouldn't work to set the time or timezone and they would need the option to at least set the timezone but still setting the time is not available. So if it were me, I would probably just raise the error and move on. Either use case, this doesn't really offer much in the way of functionality that would benefit the user in a meaningful way. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Updated in 0f3892d to keep the shared set_time() entrypoint while making the SmartCam behavior explicit and testable:
Validation run locally:
I also checked coverage for the modified SmartCam time lines; the changed executable lines are covered. |
Sorry, something went wrong.
rytilahti
approved these changes
Jul 10, 2026
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Merged
rytilahti
added a commit
that referenced
this pull request
Oct 4, 2026
## [0.11.0](https://github.com/python-kasa/python-kasa/tree/0.11.0) (2026-10-04) [Full Changelog](0.10.2...0.11.0) **Release summary:** This is a huge and long overdue release, coming more than a year and a half after the previous one. Hopefully the next one follows sooner, as the TPAP transport (which did not make it into this release) is used more and more on newer devices. This release brings broader camera support, new modules for lights, vacuums and cameras, and many connectivity fixes for newer firmware versions. Some other highlights: - Improved Tapo camera support: login version 3, presets, wifi handling, last alert detection, and more robust authentication and discovery. - Selective room cleaning for robot vacuums. - Configurable light strip length via the new strip segment module, and an exposed light transition state change flag. - Basic HomeKit module for Kasa (iot) devices. - Energy monitoring V2 support (S515D). - Better hub and thermostat state reporting (hold, summer mode, low battery). - Connection fixes for newer Tapo firmware and older SSL devices, plus KLAP v2 for iot devices. - More resilient time handling, with failover and UTC fallback for iot devices. - Python 3.14 is now supported. - Inclusion of fixtures for 29 devices or firmware versions, including the Tapo C460, C200 and C101 cameras and the KH100 hub with KE100/KE110 thermostats. **Thank you to all contributors!** A big thank you to everyone who contributed to this release, whether through code, device fixtures, bug reports or testing. Special thanks to @ZeliardM for a huge effort on both features and project maintenance, including but not limited to: - Features like the HomeKit module for iot devices, iot time module failover, wifi handling and credential improvements for cameras, Tapo login version 3, and V2 energy monitoring for S515D. - A lot of necessary maintenance work including type annotations and cleanups throughout the test suite, modernized docstrings, CI hardening with SHA-pinned actions, and many bug fixes. This helps us to keep the library maintainable and open to new contributions. A warm welcome to our new contributors, with special thanks to those who contributed improvements and fixes: - @alams154: discovery on port 20004 - @bluntman001: iot device classification fix - @bm1549: KLAP v2 transport for iot devices - @darylldelfin: cipher support for newer Tapo firmware - @davidefiocco: vacuum mop water level fix - @epg-pers: selective room cleaning for vacuums - @freeKC: camera discovery and authentication fixes - @gpongelli: extended camera detection - @Ikstar: KL420 color temperature range - @juherr: last alert detection module for cameras, camera error codes and a C200 fixture - @kad: SSL connections to older devices - @KaloyanNaumov: multi-request timeout handling - @loganrosen: KL400L5 color temperature range - @markvanpraet: Tapo C460 support and camera battery fix - @monteccarlos: iot timezone mapping fix - @mrwogu: preset support for Tapo cameras - @nopoz: strip segment module, light transition flag and credentials hash fix - @tk1475: UTC fallback for unset iot device clocks - @wh1t3f1r3: non-retryable network error handling Thanks also to our new contributors who provided device fixtures to help future development efforts: @emanueleg, @fantandrea, @HarryPehkonen, @ijaron, @Krotu, @LostLuma, @mjbohr and @TheLinuxGuy. **This release in numbers:** - 68 merged pull requests from 29 contributors, 27 of them first-time contributors - 8 new modules - 29 new device fixtures - 203 files changed, with 25,199 lines added and 2,585 removed **Implemented enhancements:** - \[Feature Request\] C220 camera line crossing detection on-off switch [\#1551](#1551) - SslAesTransport: handshake again when a camera answers 401 to passthrough [\#1771](#1771) (@freeKC) - Add LastAlertDetection module for smartcam devices [\#1762](#1762) (@juherr) - Add KL420 to TPLINK\_KELVIN color temperature ranges [\#1757](#1757) (@Ikstar) - Do not authenticate with a credentials\_hash from a different transport [\#1749](#1749) (@nopoz) - Expose the light transition state change flag [\#1745](#1745) (@nopoz) - Add strip segment module for configurable light strip length [\#1744](#1744) (@nopoz) - Add KL400L5 color temperature range [\#1719](#1719) (@loganrosen) - Update smartcam credential handling and tests [\#1664](#1664) (@ZeliardM) - Add support for V2 Energy Monitoring for S515D [\#1663](#1663) (@ZeliardM) - Add selective room cleaning to vacuum clean module [\#1660](#1660) (@epg-pers) - New Wi-Fi handling for SMARTCAM devices [\#1639](#1639) (@ZeliardM) - Add support for tapo login\_version 3 in sslaestransport [\#1638](#1638) (@ZeliardM) - Add preset support for Tapo cameras [\#1615](#1615) (@mrwogu) - Add python 3.14 to supported versions [\#1599](#1599) (@rytilahti) - Add discovery port 20004 [\#1595](#1595) (@alams154) - Implement IOT Time Module Failover [\#1583](#1583) (@ZeliardM) - Add bare bones homekit module for iot devices [\#1566](#1566) (@ZeliardM) - Extend smartcam detection support [\#1552](#1552) (@gpongelli) **Fixed bugs:** - Time module unavailable for waterleak sensor [\#1613](#1613) - 'No time zone found with key EST' in debian 13 [\#1579](#1579) - Discovery: accept cameras that only send the encrypt\_type list [\#1770](#1770) (@freeKC) - Classify IOT devices via sysinfo regardless of transport \(fixes \#1740\) [\#1769](#1769) (@bluntman001) - Fall back to UTC for iot time when the device clock is not set [\#1768](#1768) (@tk1475) - Add UNKNOWN\_USERNAME \(-60502\) camera error code [\#1761](#1761) (@juherr) - Disable multi requests on timeout during multi-request [\#1759](#1759) (@KaloyanNaumov) - Add ECDHE-RSA-AES256 cipher for newer Tapo firmware [\#1755](#1755) (@darylldelfin) - Map iot timezone index 18 to America/New\_York instead of EST [\#1743](#1743) (@monteccarlos) - fix: use KLAP v2 transport for IOT devices with login version 2 [\#1731](#1731) (@bm1549) - Add ENETUNREACH to non-retryable errors in XorTransport [\#1668](#1668) (@wh1t3f1r3) - Fix mop set\_waterlevel sending setCleanAttr without type field [\#1667](#1667) (@davidefiocco) - Fix SMARTCAM Time module and update tests [\#1659](#1659) (@ZeliardM) - Fix camera login version in CLI [\#1658](#1658) (@ZeliardM) - Allow SSL connections to older devices [\#1654](#1654) (@kad) - waterleaksensor: use parent's Time for alert timestamp [\#1614](#1614) (@rytilahti) - Add hold state to thermostatstate [\#1609](#1609) (@rytilahti) - Fix thermostat idle reporting on low battery [\#1598](#1598) (@rytilahti) - Add shutdown \(summer mode\) to thermostatstate [\#1588](#1588) (@rytilahti) - Fix iotstrip child device time handling [\#1584](#1584) (@ZeliardM) **Added support for devices:** - Add C200 device fixture [\#1760](#1760) (@juherr) - Add P125M fixture for firmware 1.4.4 [\#1746](#1746) (@HarryPehkonen) - Add fixtures for KH100, KE100 and KE110 and simulate TRV states [\#1726](#1726) (@Krotu) - Add L530EA\(EU\) device fixture [\#1694](#1694) (@ZeliardM) - Add C101 test fixture [\#1673](#1673) (@ijaron) - Add LB130\(US\) device fixture [\#1669](#1669) (@ZeliardM) - Add KL110B\(UN\) device fixture [\#1657](#1657) (@ZeliardM) - Add TS15\(US\) device fixture [\#1649](#1649) (@ZeliardM) - Add Tapo C460 support [\#1645](#1645) (@markvanpraet) - Add P105\(US\) device fixture [\#1644](#1644) (@ZeliardM) - Add L430C\(EU\) device fixture [\#1643](#1643) (@ZeliardM) - Add L430P\(EU\) device fixture [\#1607](#1607) (@LostLuma) - Add S500\(US\)\_1.0\_1.2.0 fixture [\#1569](#1569) (@ZeliardM) - Add device fixture for P316M\(US\) [\#1568](#1568) (@TheLinuxGuy) - Add L535E\(EU\) 3.0 1.1.8 fixture [\#1545](#1545) (@fantandrea) - Adding KL400L10\(US\)\_1.0\_1.0.10 fixture [\#1539](#1539) (@mjbohr) - Add TP10\(IT\) 1.0 1.2.5 fixture [\#1538](#1538) (@emanueleg) - Add LB100\(US\)\_1.0\_1.8.11 fixture file [\#1515](#1515) (@ZeliardM) - Add KS225\(US\)\_1.0\_1.1.1 and L930-5\(EU\)\_1.0\_1.2.5 [\#1509](#1509) (@ZeliardM) **Documentation updates:** - How to hash credentials to make use of --credentials-hash flag? [\#1517](#1517) - docs: modernize docstrings across the repository [\#1682](#1682) (@ZeliardM) - Add a note to emeter guide being kasa-only [\#1512](#1512) (@rytilahti) **Project maintenance:** - tests: add type annotations to top-level test files [\#1688](#1688) (@ZeliardM) - tests: add type annotations to CLI, protocol, and smartcam tests [\#1687](#1687) (@ZeliardM) - tests: add type annotations to Smart tests [\#1686](#1686) (@ZeliardM) - tests: add type annotations to IoT tests [\#1685](#1685) (@ZeliardM) - tests: add type annotations to transport tests [\#1684](#1684) (@ZeliardM) - tests: centralize transport and session cleanup in conftest [\#1683](#1683) (@ZeliardM) - ci: pin all GitHub Actions to SHA hashes and update versions [\#1681](#1681) (@ZeliardM) - tests: fix typos, child device subtype, CLI patch path, and deprecation test logic [\#1677](#1677) (@ZeliardM) - Update GitHub Workflows and Actions [\#1622](#1622) (@ZeliardM) - Use log-level debug for smartdevice query error reporting [\#1587](#1587) (@rytilahti) - Use Device instead of SmartDevice where feasible [\#1585](#1585) (@ZeliardM) **Closed issues:** - Python 3.14 Support [\#1597](#1597) - HS300 Child State - Time Module Error [\#1445](#1445)
Merged
rytilahti
added a commit
that referenced
this pull request
Oct 4, 2026
## [0.11.0.1](https://github.com/python-kasa/python-kasa/tree/0.11.0.1) (2026-10-04) [Full Changelog](0.10.2...0.11.0.1) **Release summary:** *Note: 0.11.0 was tagged but never published to PyPI due to a packaging issue. 0.11.0.1 contains the same changes plus a fix for the release workflow.* This is a huge and long overdue release, coming more than a year and a half after the previous one. Hopefully the next one follows sooner, as the TPAP transport (which did not make it into this release) is used more and more on newer devices. This release brings broader camera support, new modules for lights, vacuums and cameras, and many connectivity fixes for newer firmware versions. Some other highlights: - Improved Tapo camera support: login version 3, presets, wifi handling, last alert detection, and more robust authentication and discovery. - Selective room cleaning for robot vacuums. - Configurable light strip length via the new strip segment module, and an exposed light transition state change flag. - Basic HomeKit module for Kasa (iot) devices. - Energy monitoring V2 support (S515D). - Better hub and thermostat state reporting (hold, summer mode, low battery). - Connection fixes for newer Tapo firmware and older SSL devices, plus KLAP v2 for iot devices. - More resilient time handling, with failover and UTC fallback for iot devices. - Python 3.14 is now supported. - Inclusion of fixtures for 29 devices or firmware versions, including the Tapo C460, C200 and C101 cameras and the KH100 hub with KE100/KE110 thermostats. **Thank you to all contributors!** A big thank you to everyone who contributed to this release, whether through code, device fixtures, bug reports or testing. Special thanks to @ZeliardM for a huge effort on both features and project maintenance, including but not limited to: - Features like the HomeKit module for iot devices, iot time module failover, wifi handling and credential improvements for cameras, Tapo login version 3, and V2 energy monitoring for S515D. - A lot of necessary maintenance work including type annotations and cleanups throughout the test suite, modernized docstrings, CI hardening with SHA-pinned actions, and many bug fixes. This helps us to keep the library maintainable and open to new contributions. A warm welcome to our new contributors, with special thanks to those who contributed improvements and fixes: - @alams154: discovery on port 20004 - @bluntman001: iot device classification fix - @bm1549: KLAP v2 transport for iot devices - @darylldelfin: cipher support for newer Tapo firmware - @davidefiocco: vacuum mop water level fix - @epg-pers: selective room cleaning for vacuums - @freeKC: camera discovery and authentication fixes - @gpongelli: extended camera detection - @Ikstar: KL420 color temperature range - @juherr: last alert detection module for cameras, camera error codes and a C200 fixture - @kad: SSL connections to older devices - @KaloyanNaumov: multi-request timeout handling - @loganrosen: KL400L5 color temperature range - @markvanpraet: Tapo C460 support and camera battery fix - @monteccarlos: iot timezone mapping fix - @mrwogu: preset support for Tapo cameras - @nopoz: strip segment module, light transition flag and credentials hash fix - @tk1475: UTC fallback for unset iot device clocks - @wh1t3f1r3: non-retryable network error handling Thanks also to our new contributors who provided device fixtures to help future development efforts: @emanueleg, @fantandrea, @HarryPehkonen, @ijaron, @Krotu, @LostLuma, @mjbohr and @TheLinuxGuy. **This release in numbers:** - 68 merged pull requests from 29 contributors, 27 of them first-time contributors - 8 new modules - 29 new device fixtures - 203 files changed, with 25,199 lines added and 2,585 removed **Implemented enhancements:** - \[Feature Request\] C220 camera line crossing detection on-off switch [\#1551](#1551) - SslAesTransport: handshake again when a camera answers 401 to passthrough [\#1771](#1771) (@freeKC) - Add LastAlertDetection module for smartcam devices [\#1762](#1762) (@juherr) - Add KL420 to TPLINK\_KELVIN color temperature ranges [\#1757](#1757) (@Ikstar) - Do not authenticate with a credentials\_hash from a different transport [\#1749](#1749) (@nopoz) - Expose the light transition state change flag [\#1745](#1745) (@nopoz) - Add strip segment module for configurable light strip length [\#1744](#1744) (@nopoz) - Add KL400L5 color temperature range [\#1719](#1719) (@loganrosen) - Update smartcam credential handling and tests [\#1664](#1664) (@ZeliardM) - Add support for V2 Energy Monitoring for S515D [\#1663](#1663) (@ZeliardM) - Add selective room cleaning to vacuum clean module [\#1660](#1660) (@epg-pers) - New Wi-Fi handling for SMARTCAM devices [\#1639](#1639) (@ZeliardM) - Add support for tapo login\_version 3 in sslaestransport [\#1638](#1638) (@ZeliardM) - Add preset support for Tapo cameras [\#1615](#1615) (@mrwogu) - Add python 3.14 to supported versions [\#1599](#1599) (@rytilahti) - Add discovery port 20004 [\#1595](#1595) (@alams154) - Implement IOT Time Module Failover [\#1583](#1583) (@ZeliardM) - Add bare bones homekit module for iot devices [\#1566](#1566) (@ZeliardM) - Extend smartcam detection support [\#1552](#1552) (@gpongelli) **Fixed bugs:** - Time module unavailable for waterleak sensor [\#1613](#1613) - 'No time zone found with key EST' in debian 13 [\#1579](#1579) - Discovery: accept cameras that only send the encrypt\_type list [\#1770](#1770) (@freeKC) - Classify IOT devices via sysinfo regardless of transport \(fixes \#1740\) [\#1769](#1769) (@bluntman001) - Fall back to UTC for iot time when the device clock is not set [\#1768](#1768) (@tk1475) - Add UNKNOWN\_USERNAME \(-60502\) camera error code [\#1761](#1761) (@juherr) - Disable multi requests on timeout during multi-request [\#1759](#1759) (@KaloyanNaumov) - Add ECDHE-RSA-AES256 cipher for newer Tapo firmware [\#1755](#1755) (@darylldelfin) - Map iot timezone index 18 to America/New\_York instead of EST [\#1743](#1743) (@monteccarlos) - fix: use KLAP v2 transport for IOT devices with login version 2 [\#1731](#1731) (@bm1549) - Add ENETUNREACH to non-retryable errors in XorTransport [\#1668](#1668) (@wh1t3f1r3) - Fix mop set\_waterlevel sending setCleanAttr without type field [\#1667](#1667) (@davidefiocco) - Fix SMARTCAM Time module and update tests [\#1659](#1659) (@ZeliardM) - Fix camera login version in CLI [\#1658](#1658) (@ZeliardM) - Allow SSL connections to older devices [\#1654](#1654) (@kad) - waterleaksensor: use parent's Time for alert timestamp [\#1614](#1614) (@rytilahti) - Add hold state to thermostatstate [\#1609](#1609) (@rytilahti) - Fix thermostat idle reporting on low battery [\#1598](#1598) (@rytilahti) - Add shutdown \(summer mode\) to thermostatstate [\#1588](#1588) (@rytilahti) - Fix iotstrip child device time handling [\#1584](#1584) (@ZeliardM) **Added support for devices:** - Add C200 device fixture [\#1760](#1760) (@juherr) - Add P125M fixture for firmware 1.4.4 [\#1746](#1746) (@HarryPehkonen) - Add fixtures for KH100, KE100 and KE110 and simulate TRV states [\#1726](#1726) (@Krotu) - Add L530EA\(EU\) device fixture [\#1694](#1694) (@ZeliardM) - Add C101 test fixture [\#1673](#1673) (@ijaron) - Add LB130\(US\) device fixture [\#1669](#1669) (@ZeliardM) - Add KL110B\(UN\) device fixture [\#1657](#1657) (@ZeliardM) - Add TS15\(US\) device fixture [\#1649](#1649) (@ZeliardM) - Add Tapo C460 support [\#1645](#1645) (@markvanpraet) - Add P105\(US\) device fixture [\#1644](#1644) (@ZeliardM) - Add L430C\(EU\) device fixture [\#1643](#1643) (@ZeliardM) - Add L430P\(EU\) device fixture [\#1607](#1607) (@LostLuma) - Add S500\(US\)\_1.0\_1.2.0 fixture [\#1569](#1569) (@ZeliardM) - Add device fixture for P316M\(US\) [\#1568](#1568) (@TheLinuxGuy) - Add L535E\(EU\) 3.0 1.1.8 fixture [\#1545](#1545) (@fantandrea) - Adding KL400L10\(US\)\_1.0\_1.0.10 fixture [\#1539](#1539) (@mjbohr) - Add TP10\(IT\) 1.0 1.2.5 fixture [\#1538](#1538) (@emanueleg) - Add LB100\(US\)\_1.0\_1.8.11 fixture file [\#1515](#1515) (@ZeliardM) - Add KS225\(US\)\_1.0\_1.1.1 and L930-5\(EU\)\_1.0\_1.2.5 [\#1509](#1509) (@ZeliardM) **Documentation updates:** - How to hash credentials to make use of --credentials-hash flag? [\#1517](#1517) - docs: modernize docstrings across the repository [\#1682](#1682) (@ZeliardM) - Add a note to emeter guide being kasa-only [\#1512](#1512) (@rytilahti) **Project maintenance:** - Fix PyPI publishing for packages with metadata 2.5 [\#1779](#1779) (@rytilahti) - tests: add type annotations to top-level test files [\#1688](#1688) (@ZeliardM) - tests: add type annotations to CLI, protocol, and smartcam tests [\#1687](#1687) (@ZeliardM) - tests: add type annotations to Smart tests [\#1686](#1686) (@ZeliardM) - tests: add type annotations to IoT tests [\#1685](#1685) (@ZeliardM) - tests: add type annotations to transport tests [\#1684](#1684) (@ZeliardM) - tests: centralize transport and session cleanup in conftest [\#1683](#1683) (@ZeliardM) - ci: pin all GitHub Actions to SHA hashes and update versions [\#1681](#1681) (@ZeliardM) - tests: fix typos, child device subtype, CLI patch path, and deprecation test logic [\#1677](#1677) (@ZeliardM) - Update GitHub Workflows and Actions [\#1622](#1622) (@ZeliardM) - Use log-level debug for smartdevice query error reporting [\#1587](#1587) (@rytilahti) - Use Device instead of SmartDevice where feasible [\#1585](#1585) (@ZeliardM) **Closed issues:** - Python 3.14 Support [\#1597](#1597) - HS300 Child State - Time Module Error [\#1445](#1445)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
Update SmartCam time handling to apply timezone-only changes with explicit warnings, while keeping common time and CLI tests focused on devices that support setting clock time and adding SmartCam-specific coverage for the special behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update the SMARTCAM Time module so that manually setting the time will function correctly. An important note is that this turns off NTP time updating.