Repository navigation
Strip multi-word rich tags when rich is not installed - #1807
Merged
rytilahti merged 1 commit intoOct 24, 2026
Merged
rytilahti merged 1 commit into
rytilahti merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The fallback regex matched only single-word tags such as [bold], so error() printed [bold red]...[/bold red] verbatim. Allow space-separated lowercase words, keeping uppercase bracketed device data intact. Fixes #1524
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1807 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 160 160
Lines 10095 10095
Branches 1042 1042
=======================================
Hits 9432 9432
Misses 471 471
Partials 192 192 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
rytilahti
approved these changes
Oct 24, 2026
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks @wolfgang-aura!
Sorry, something went wrong.
Merged
rytilahti
added a commit
that referenced
this pull request
Oct 25, 2026
## [0.12.0](https://github.com/python-kasa/python-kasa/tree/0.12.0) (2026-10-25) This release include several compatibility fixes (updated accepted SSL ciphers, removal of Homekit from the default update cycle). The new API `Device.supports_module()` provide a way to find out if the device supports some specific module, e.g., HomeKit, without including it in the default update cycle. [Full Changelog](0.11.0.1...0.12.0) **Fixed bugs:** - Keep hub children when the child component list is missing [\#1797](#1797) (@Richardtristan) - Strip multi-word rich tags when rich is not installed [\#1807](#1807) (@wolfgang-aura) - Add Device.supports_module() and stop querying HomeKit for iot devices [\#1808](#1808) (@rytilahti) - Keep multi requests for smartcam devices after a timeout [\#1802](#1802) (@hugaraujo) - Consolidate SSL ciphers and use them in SslTransport [\#1798](#1798) (@rytilahti) - Raise UnsupportedDeviceError instead of crashing on unknown device types [\#1781](#1781) (@GhostCoder6969) **Added support for devices:** - Add TD21(EU) device fixture [\#1786](#1786) (@Smugaski) - Add P116M(IN) fixture [\#1795](#1795) (@Partha-dev01) **Project maintenance:** - Add Python 3.15 to supported versions and update pins [\#1793](#1793) (@rytilahti) - Generate the changelog with git-cliff and draft releases in CI [\#1809](#1809) (@rytilahti) - Build and check packages in CI and publish workflows [\#1782](#1782) (@rytilahti) **Other changes:** - Use the real discovery reply in the TD21 fixture [\#1800](#1800) (@Smugaski)
2 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without rich installed, kasa prints tags like [bold red]Only discover is available without --host or --alias[/bold red] verbatim. The fallback in kasa/cli/common.py strips only single-word tags (\[/?[a-z]+]), and error() uses the two-word [bold red].
I changed the pattern to \[/?[a-z]+(?: [a-z]+)*], so space-separated lowercase words are stripped too. It is still lowercase only, so bracketed device data such as [ABC] is left alone, as #703 intended. Nothing changes when rich is installed.
The new test in tests/test_cli.py loads a fresh copy of kasa.cli.common with rich blocked and checks that [bold red]...[/bold red] [ABC] prints as ... [ABC]. It fails without the fix.
Tests: pytest tests/test_cli.py, 7019 passed, 204 skipped. ruff check and ruff format --check are clean on both files.
Fixes #1524
This change was prepared with an AI coding assistant (Claude Code, claude-sonnet-5-5) and reviewed before submission.