| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
build: deprecated addNewAtom
build: deprecate getLastAtom and add a test
chore: deprecate read/writeStr, placeInLattice method
chore: deprecate private function in utils
chore: deprecate setLatPar and setLatBase method
chore: deprecate abcABG and readStr method
chore: deprecate methods in `symmetryutilities.py`
…ies-1 chore: deprecate expansion functional utilities method.
chore: deprecate apps method
chore: deprecate spacegroup method
chore: deprecate Atom class method
chore: change utility script to snake_case method.
fix: fix load_structure method with loading Path object.
chore: add readme.md for devutils files
feat: add vesta viewer
|
@stevenhua0320 please could you look at this PR? It seems to be failing pre-commit because of an undefined variable. Also, I saw it import bareAtomLabel or something like that which we may need to deprecate? |
Sorry, something went wrong.
It seems that because of my first deprecation of method assignUniqueLabels is accidentally done on the main branch at the very beginning, and at that time we don't want to cover this method again in v3.4.0 and now github identifies the difference, so it believes we delete the change on assignUniqueLabels method. So a proper fix I believe is to make the change for assignUniqueLabels also on v3.4.0 so that this method is consistent with the change we have done in main. For the bareAtomSymbol, I believe we have deprecated that method in v3.4.0, so the only change we need to make is to change the usage to bare_atom_symbol. I would make a PR shortly to branch v3.4.0 |
Sorry, something went wrong.
|
Ok. Sounds good. Are you able to make a PR? |
Sorry, something went wrong.
Have made that PR, see #190 |
Sorry, something went wrong.
…tion chore: add assignUniqueLabels deprecation message
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 98.93% 99.20% +0.26%
==========================================
Files 13 15 +2
Lines 1884 2507 +623
==========================================
+ Hits 1864 2487 +623
Misses 20 20
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.