| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
PR-URL: nodejs#4536 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#4538 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: nodejs#3254 PR-URL: nodejs#4540 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#4549 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Adds Myles Borins and his public key to the README PR-URL: nodejs#4578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Adds Evan Lucas and his public key to the README for releases PR-URL: nodejs#4579 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
fix description about the latest LTS release download page to make it clear PR-URL: nodejs#4583 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: nodejs#4589 Fixes: nodejs#4576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
The server method returns `self` in order to allow chaining. PR-URL: nodejs#4590 Fixes: nodejs#4571 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: nodejs#4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
- Changed colors to match frontpage as close as possible. - Links are slightly more horizontally padded as compared before to accomodate for the hover effect. - Slightly reduced the scroll indication height on the TOC. - The main content is now offset using margin instead of the previous border hack. - remove empty footer that was rendering a dark bar on the bottom of each page without any content. PR-URL: nodejs#4621 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Useful to have for reference, especially for onboarding PR-URL: nodejs#4636 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell<jasnell@gmail.com>
PR-URL: nodejs#4656 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Original key did not have personal information associated with it. The new key rectifies this problem PR-URL: nodejs#4657 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements.
Sorry, something went wrong.
|
@Trott ... PR has some linting issues: https://ci.nodejs.org/job/node-test-commit/1736/ |
Sorry, something went wrong.
|
@jasnell I'm betting those linter issues have more to do with the recently committed changes to the linter. |
Sorry, something went wrong.
|
Yeah, it's unlikely that this PR, which removes two lines of code and adds zero lines of code, would generate 219 linting errors. Those errors are already in v4.x-staging and were not introduced in this PR. Here's a lint run against current v4.x-staging: https://ci.nodejs.org/job/node-test-linter/859/ |
Sorry, something went wrong.
|
;-) I saw the red button but didn't look into the details. /cc @thealphanerd |
Sorry, something went wrong.
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: nodejs#4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: #4683 Reviewed-By: Myles Borins <mborins@us.ibm.com>
| Back | FazBrowse Home | New Git URL |
Some files in lib were using require to load modules that were
subsequently not used in the file. This removes those require
statements.