2025-06-09, Version 24.2.0 (Current) - #58635
Merged
aduh95 merged 156 commits intoJun 9, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR-URL: #56491 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #58124 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58306 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
PR-URL: #58269 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Since `String::Write()` is deprecated, use `String::Write2()` instead. That requires us to compute the correct number of characters ahead of time but removes the need for dealing with the return value. PR-URL: #58165 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #58325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
`EXTENSIONLESS_FORMAT_JAVASCRIPT` and `EXTENSIONLESS_FORMAT_WASM` are only used internally through binding `getFormatOfExtensionlessFile`. They should not be exposed publicly. PR-URL: #58327 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This was added for AIX but should have included IBM i as well. PR-URL: #58335 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #58296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #58296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #58307 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
`Utf8Length()` is deprecated and was replaced during the V8 update, but a subsequent commit introduced a new occurrence. Refs: #58070 Refs: #58048 PR-URL: #58156 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58317 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #58152 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Previously, the 'net.client.socket' diagnostics channel was only published to when `net.connect()` was called. This change ensures the message is also published for the following calls: - net.createConnection() - net.Socket#connect() - tls.connect() Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58349 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #58268 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Both `createCipher()` and `createDecipher()` were removed in Node.js 22. PR-URL: #58363 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
As of 0315283, the libuv `UV_TTY_MODE_RAW_VT` flag is available for applications on Windows in order to have the terminal itself translate keypresses into control sequences, rather than libuv. This aligns the TTY setup more closely with POSIX platforms, and enables handling of control sequences in applications which libuv is not able to emit at all. Since the Node.js `readline` implementation already handles divergences between different control character sequences for the same keypresses (e.g. `<ESC>[[A` vs `<ESC>OP` for the F1 key), this should not present a visible change for typical Node.js TTY applications. Testing is handled on the libuv side, and not easily feasible with Node.js’s current TTY test setup. PR-URL: #58358 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
- Remove usage of deprecated V8::InitializeSandbox(). - External code space and pointer compression shared cage must be enabled when pointer compression builds are enabled. - We cannot enable the sandbox because that requires allocating the array buffer backing stores in the sandbox - we currently have many backing stores tied to pointers from C++ land that are not even necessarily dynamic (e.g. in static storage). Until we manage to get rid of all those, sandbox cannot be enabled. Note that enabling pointer compression without enabling sandbox is unsupported by V8, and can be broken at any time. PR-URL: #58171 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
V8 isolate group initialization forces allocation of the virtual memory cage with pointer compression builds and simply would not work when there is a smaller hard limit on the virtual memory. PR-URL: #58171 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58329 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Added a parameter to allow severity-based formatting for diagnostic messages. Defaults to 'info'. This update enables better control over message presentation (e.g., coloring) based on severity levels such as 'info', 'warn', and 'error'. Refs: #55922 PR-URL: #57923 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add ChaCha20-Poly1305 to the algorithms for which we ensure that the authentication tag can be set either before or after calling `update()`. PR-URL: #58367 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
`path.resolve()` and `path.resolve('.')` is frequently called as
alternative to process.cwd(). This minimized overhead for these
specific cases.
PR-URL: #58362
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This loop used to iterate over two elements, but since commit 215f4d0, it only iterates over a single element. Therefore, move the test out of the loop body and remove the loop itself. Refs: #50973 PR-URL: #58368 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #58001 Refs: #53946 Refs: nodejs/undici#4166 Reviewed-By: James M Snell <jasnell@gmail.com>
This allows us to perform cleanups of cppgc wrappers that rely on a
living Realm during Realm shutdown. Otherwise the cleanup may happen
during object destruction, which can be triggered by GC after Realm
shutdown, leading to invalid access to Realm.
The general pattern for this type of non-trivial destruction is
designed to be:
```
class MyWrap final : CPPGC_MIXIN(MyWrap) {
public:
~MyWrap() { this->Finalize(); }
void Clean(Realm* realm) override {
// Do cleanup that relies on a living Realm. This would be
// called by CppgcMixin::Finalize() first during Realm
// shutdown, while the Realm is still alive. If the destructor
// calls Finalize() again later during garbage collection that
// happens after Realm shutdown, Clean() would be skipped,
// preventing invalid access to the Realm.
}
}
```
In addition, this allows us to trace external memory held by the
wrappers in the heap snapshots if we add synthethic edges between the
wrappers and other nodes in the embdder graph callback, or to perform
snapshot serialization for them.
PR-URL: #56534
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 8, 2025
Notable changes: doc: * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 94.69469% with 53 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## v24.x #58635 +/- ##
==========================================
- Coverage 90.24% 90.15% -0.09%
==========================================
Files 632 635 +3
Lines 187024 188278 +1254
Branches 36711 36941 +230
==========================================
+ Hits 168775 169742 +967
- Misses 11043 11280 +237
- Partials 7206 7256 +50
... and 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635
aduh95
force-pushed
the
v24.2.0-proposal
branch
5 times, most recently
from
b77f158 to
e3b50d3
Compare
June 9, 2025 14:39
aduh95
pushed a commit
that referenced
this pull request
Jun 9, 2025
Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
approved these changes
Jun 9, 2025
aduh95
pushed a commit
that referenced
this pull request
Jun 9, 2025
Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) #58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) #58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) #58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) #58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) #58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) #58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #58635
aduh95
added a commit
to aduh95/nodejs.org
that referenced
this pull request
Jun 9, 2025
5 tasks
aduh95
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jun 9, 2025
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
Notable changes: doc: * add Filip Skokan to TSC (Rafael Gonzaga) nodejs#58499 * deprecate `util.isNativeError` in favor of `Error.isError` (Miguel Marcondes Filho) nodejs#58262 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) nodejs#58564 * deprecate HTTP/2 priority signaling (Matteo Collina) nodejs#58313 * (SEMVER-MINOR) graduate `Symbol.dispose`/`asyncDispose` from experimental (James M Snell) nodejs#58467 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) nodejs#57804 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) nodejs#58548 http: * deprecate instantiating classes without new (Yagiz Nizipli) nodejs#58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) nodejs#58560 * (SEMVER-MAJOR) remove support for priority signaling (Matteo Collina) nodejs#58293 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) nodejs#58541 perf_hooks: * (SEMVER-MINOR) make event loop delay histogram disposable (James M Snell) nodejs#58384 src: * (SEMVER-MINOR) support namespace options in configuration file (Pietro Marchini) nodejs#58073 permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) nodejs#58579 test: * (SEMVER-MINOR) add disposable histogram test (James M Snell) nodejs#58384 * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) nodejs#58385 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) nodejs#58437 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#58635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for HTTP/2 priority signaling
The support for priority signaling has been removed in nghttp2, following its
deprecation in the RFC 9113.
As a consequence of this, priority signaling is deprecated on all release lines of Node.js,
and removed from Node.js 24 so we can include latest updates from nghttp2.
Contributed by Matteo Collina and Antoine du Hamel in #58293.
import.meta.main is now available
Boolean value available in ECMAScript modules, which can be used to detect
whether the current module was the entry point of the current process.
Contributed by Joe and Antoine du Hamel in #57804.
Other Notable Changes
- [e13930bbe0] - doc: add Filip Skokan to TSC (Rafael Gonzaga) #58499
- [984894b38c] - doc: deprecate util.isNativeError in favor of Error.isError (Miguel Marcondes Filho) #58262
- [d261274b0f] - doc: deprecate passing an empty string to options.shell (Antoine du Hamel) #58564
- [510872a522] - (SEMVER-MINOR) doc: graduate Symbol.dispose/asyncDispose from experimental (James M Snell) #58467
- [6f4c9dd423] - (SEMVER-MINOR) fs: add autoClose option to FileHandle readableWebStream (James M Snell) #58548
- [32efb63242] - http: deprecate instantiating classes without new (Yagiz Nizipli) #58518
- [0234a8ef53] - (SEMVER-MINOR) http2: add diagnostics channel http2.server.stream.finish (Darshan Sen) #58560
- [0f1e94f731] - (SEMVER-MINOR) lib: graduate error codes that have been around for years (James M Snell) #58541
- [13abca3c26] - (SEMVER-MINOR) perf_hooks: make event loop delay histogram disposable (James M Snell) #58384
- [8ea1fc5f3b] - (SEMVER-MINOR) src: support namespace options in configuration file (Pietro Marchini) #58073
- [d6ea36ad6c] - src,permission: implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579
- [5936cef60a] - (SEMVER-MINOR) test: add disposable histogram test (James M Snell) #58384
- [7a91f4aaa1] - (SEMVER-MINOR) test: add test for async disposable worker thread (James M Snell) #58385
- [532c173cf2] - (SEMVER-MINOR) util: add none style to styleText (James M Snell) #58437
- [aeb9ab4c4c] - (SEMVER-MINOR) worker: make Worker async disposable (James M Snell) #58385
Commits